From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Josh Soref" <gitgitgadget@gmail.com>
Cc: Haritha <harithamma.d@ibm.com>, git@vger.kernel.org
Subject: Re: [PATCH] This PR enables a successful git build on z/OS.
Date: Wed, 31 Jan 2024 17:12:27 +0100 [thread overview]
Message-ID: <4d0efd0f-f35d-4a3a-aea1-e08cc55bd2d9@app.fastmail.com> (raw)
In-Reply-To: <pull.1663.git.git.1706710861778.gitgitgadget@gmail.com>
Hi
> [PATCH] This PR enables a successful git build on z/OS.
Maybe the subject could be:
> [PATCH] build: support z/OS (OS/390)
There’s some indirectly related things in `SubmittingPatches`:
“ Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behavior. Try to make sure your explanation can be understood
without external resources. Instead of giving a URL to a mailing
list archive, summarize the relevant points of the discussion.
From which I infer that “This PR” is considered redundant.
As for the `build:` prefix: many different prefixes have been used for
this file (`git log --no-merges -- config.mak.uname`).
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-01-31 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:21 [PATCH] This PR enables a successful git build on z/OS Haritha via GitGitGadget
2024-01-31 16:12 ` Kristoffer Haugsbakk [this message]
2024-01-31 17:58 ` Junio C Hamano
2024-01-31 17:12 ` Junio C Hamano
2024-02-23 3:48 ` [PATCH v2 0/2] " Haritha via GitGitGadget
2024-02-23 3:48 ` [PATCH v2 1/2] build: support z/OS (OS/390) Haritha D via GitGitGadget
2024-02-23 3:48 ` [PATCH v2 2/2] an improvement: removed configure.ac changes Haritha D via GitGitGadget
2024-02-23 7:38 ` Junio C Hamano
2024-02-23 7:37 ` [PATCH v2 0/2] This PR enables a successful git build on z/OS Junio C Hamano
2024-02-25 6:10 ` [PATCH v3] build: support z/OS (OS/390) Haritha via GitGitGadget
2024-02-26 17:30 ` Junio C Hamano
2024-03-01 9:09 ` Haritha D
2024-03-01 14:39 ` Ghanshyam Thakkar
2024-03-01 18:15 ` Junio C Hamano
2024-03-01 18:25 ` rsbecker
2024-03-04 4:19 ` Haritha D
2024-03-06 5:44 ` [PATCH v4] " Haritha via GitGitGadget
2024-03-06 16:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d0efd0f-f35d-4a3a-aea1-e08cc55bd2d9@app.fastmail.com \
--to=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=harithamma.d@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).