git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Jonathan del Strother" <maillist@steelskies.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Prompt to continue when editing during rebase --interactive
Date: Wed, 27 Feb 2008 14:22:33 +0100	[thread overview]
Message-ID: <4d8e3fd30802270522v21da6c6cx73988361de4aae5@mail.gmail.com> (raw)
In-Reply-To: <57518fd10802270450r27e7339cs7612eab733d4e94e@mail.gmail.com>

On Wed, Feb 27, 2008 at 1:50 PM, Jonathan del Strother
<maillist@steelskies.com> wrote:
> On hitting an edit point in an interactive rebase, git should prompt
>  the user to run "git rebase --continue"

Very nice, I hit the same UI defect a few days ago but I didn't have time
to try to fix it.

>  Signed-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv>

FWIW,
Acked-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>

>
>   git-rebase--interactive.sh |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
>  diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
>  index fb12b03..c2bedd6 100755
>  --- a/git-rebase--interactive.sh
>  +++ b/git-rebase--interactive.sh
>  @@ -268,6 +268,10 @@ do_next () {
>                 warn
>                 warn "  git commit --amend"
>                 warn
>  +               warn "Once you are satisfied with your changes, run"
>  +               warn
>  +               warn "  git rebase --continue"
>  +               warn
>                 exit 0
>                 ;;
>         squash|s)
>  --
>  1.5.4.1.97.g40aab
>  -
>  To unsubscribe from this list: send the line "unsubscribe git" in
>  the body of a message to majordomo@vger.kernel.org
>  More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

  reply	other threads:[~2008-02-27 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 12:50 [PATCH] Prompt to continue when editing during rebase --interactive Jonathan del Strother
2008-02-27 13:22 ` Paolo Ciarrocchi [this message]
2008-02-27 19:48 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8e3fd30802270522v21da6c6cx73988361de4aae5@mail.gmail.com \
    --to=paolo.ciarrocchi@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=maillist@steelskies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).