git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Eric Raible" <raible@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial
Date: Mon, 25 Aug 2008 22:42:44 +0030	[thread overview]
Message-ID: <4d8e3fd30808251512x126502bj5f154b58d7ae51a2@mail.gmail.com> (raw)
In-Reply-To: <7v63pog3rn.fsf@gitster.siamese.dyndns.org>

On 8/25/08, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Raible <raible@gmail.com> writes:
>
>> Paolo Ciarrocchi <paolo.ciarrocchi <at> gmail.com> writes:
>>
>>> +Alice can also use gitk to browse that Bob did:
>>
>> s/that/what/ ?
>>
>>> +------------------------------------------------
>>> +alice$ gitk master origin/master
>>> +------------------------------------------------
>>
>> I think that you meant:
>>
>> alice$ gitk master..origin/master
>
>
> I'd suggest rewording the explanation to have Alice "compare what both of
> them did", not just "browse what Bob did".

yes, what i wrote was unclear. I managed to confuse myself too :-)

> And for that purpose, I think the original form used by Paolo's patch is
> the most appropriate here in an early part of the tutorial, as it teaches
> how to view full histories leading to the tips of these two branches.

well, it might be a good idea to mention both.

do you think we should add a note about git log --graph as well?

> Earlier in the tutorial sequence we teach "gitk" without any parameter to
> view the history of the current branch, and here the user learns one new
> thing, to view more than just the current branch.

i think we should use the nice gitk output in other sections of the
document as well, i'll send some more patches.

> Limiting the output with "..origin/master" (or "...origin/master") can be
> taught after demonstrating this most basic form.


what wording would you use to clearly explain the difference between
..origin/master and ...origin/master ?

anyway, thanks for the commentr. I'll send a new patch in 24 hours.

ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

  reply	other threads:[~2008-08-25 22:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25 19:50 [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial Paolo Ciarrocchi
2008-08-25 20:12 ` Eric Raible
2008-08-25 20:33   ` Paolo Ciarrocchi
2008-08-25 21:53   ` Junio C Hamano
2008-08-25 22:12     ` Paolo Ciarrocchi [this message]
2008-08-26  0:29       ` Junio C Hamano
2008-08-26  8:16         ` Paolo Ciarrocchi
2008-08-26  8:24           ` Eric Raible
2008-08-26  8:45             ` Paolo Ciarrocchi
2008-08-26  9:44               ` Paolo Ciarrocchi
2008-08-26 18:13           ` Junio C Hamano
2008-08-27  7:58             ` Paolo Ciarrocchi
     [not found]               ` <402731c90808270121t5c09efd1m3b60a1ad15f8f705@mail.gmail.com>
2008-08-27  8:26                 ` Paolo Ciarrocchi
2008-08-27 18:06               ` Junio C Hamano
2008-08-28 13:03                 ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8e3fd30808251512x126502bj5f154b58d7ae51a2@mail.gmail.com \
    --to=paolo.ciarrocchi@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=raible@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).