From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: How to execute a command on git am/rebase/cherry pick --abort ?
Date: Mon, 29 Jan 2024 17:35:27 +0300 [thread overview]
Message-ID: <4dd609ae2a33f3729291ff26b40632c8eb5decae.camel@yandex.ru> (raw)
In-Reply-To: <Zaknu0nwBucHVJPP@tanuki>
On Thu, 2024-01-18 at 14:29 +0100, Patrick Steinhardt wrote:
> On Thu, Jan 18, 2024 at 03:53:21PM +0300, Konstantin Kharlamov wrote:
> > (please keep me CC'ed, I'm not subscribed)
> >
> > Hello!
> >
> > There's a well-known problem of git not fully checking out changes
> > while doing e.g. `git checkout` and similar commands when you have
> > submodules. So e.g. if HEAD changes a submodule commit and you do
> > an
> > interactive rebase to HEAD~2, you may be lucky to find a submodule
> > commit change in `git diff` (because if you don't get lucky, you
> > won't
> > notice that and commit the change to the unrelated HEAD~2).
> >
> > As a workaround I have a `git submodule update` inside `post-
> > checkout`
> > hook.
> >
> > Now, the problem is I still often finding myself having the wrong
> > submodule ID, and I tracked down that problem to commands such as
> > `am/rebase/cherry-pick --abort` also not updating the submodule,
> > nor
> > executing `post-checkout`.
> >
> > I looked through `man githooks` but couldn't find any way to
> > execute a
> > `git submodule update` during these aborts.
> >
> > Any ideas how to fix these?
>
> Are you aware of the `submodule.recurse` config? If set, it should
> cause
> git-checkout(1) and many other commands to recurse into submodules
> and
> update them accordingly. This should both make your post-checkout
> hook
> obsolete and should also work with git-cherry-pick(1) et al.
It doesn't seem to work ☹ I've set it, and now supposed my top commit
changes submodule. So I do a `git rebase -i HEAD~2` and "reword" the
previous commit. After "reword"ing is done, git returns me back to HEAD
commit and when I execute `git diff` I see the submodule ID changed ☹
next prev parent reply other threads:[~2024-01-29 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 12:53 How to execute a command on git am/rebase/cherry pick --abort ? Konstantin Kharlamov
2024-01-18 13:29 ` Patrick Steinhardt
2024-01-18 13:30 ` Konstantin Kharlamov
2024-01-29 14:35 ` Konstantin Kharlamov [this message]
2024-01-29 14:40 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd609ae2a33f3729291ff26b40632c8eb5decae.camel@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox