From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c"
Date: Sat, 26 Sep 2026 02:24:15 +0530 [thread overview]
Message-ID: <4e26b51a-f811-4548-97e0-6570680efa13@gmail.com> (raw)
In-Reply-To: <20260924-pks-create-repository-stateless-v1-4-11499557cf31@pks.im>
On 9/24/26 14:49, Patrick Steinhardt wrote:
>
> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index e45268f1ff..34215bbf18 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -171,9 +171,6 @@ int cmd_init_db(int argc,
> die(_("unknown ref storage format '%s'"), ref_format);
> }
>
> - if (init_shared_repository != -1)
> - repo_settings_set_shared_repository(the_repository, init_shared_repository);
> -
> /*
> * GIT_WORK_TREE makes sense only in conjunction with GIT_DIR
> * without --bare. Catch the error early.
I was wondering if there'll be any function that between here and the
create_repository call that may use the_repository. I could not find any
from my reading of the code, though. So, this looks good to me.
-
Sivaraam
next prev parent reply other threads:[~2026-09-25 20:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 9:19 [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:01 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-25 19:49 ` Kaartic Sivaraam
2026-09-28 7:15 ` Patrick Steinhardt
2026-09-28 9:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-25 20:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-25 20:54 ` Kaartic Sivaraam [this message]
2026-09-28 9:13 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:18 ` Karthik Nayak
2026-09-28 9:52 ` Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-25 21:08 ` [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 9:20 ` Karthik Nayak
2026-09-28 9:51 ` [PATCH v2 " Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-28 12:15 ` [PATCH v2 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 12:19 ` Kaartic Sivaraam
2026-09-28 12:48 ` Patrick Steinhardt
2026-09-28 15:59 ` Junio C Hamano
2026-09-28 12:48 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e26b51a-f811-4548-97e0-6570680efa13@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox