From: Derrick Stolee <derrickstolee@github.com>
To: "Miaoqian Lin" <linmq006@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v2] commit-graph: Fix missing closedir in expire_commit_graphs
Date: Mon, 19 Sep 2022 11:04:46 -0400 [thread overview]
Message-ID: <4f1cf64e-2864-a979-6f75-d9d4148d57da@github.com> (raw)
In-Reply-To: <20220919141441.5644-1-linmq006@gmail.com>
On 9/19/2022 10:14 AM, Miaoqian Lin wrote:
> The function calls opendir() but missing the corresponding
> closedir() before exit the function.
> Add missing closedir() to fix it.
Thanks for the patch, Miaoqian.
I only have a very tiny nitpick with the line breaks in your
commit message. Either the "Add missing..." sentence should
start immediately after the previous sentence or have another
line break between the paragraphs. This shouldn't merit a
re-roll, but keep it in mind for future contributions.
> out:
> + if(dir)
> + closedir(dir);
> strbuf_release(&path);
> }
This change looks correct to me. Thanks!
-Stolee
next prev parent reply other threads:[~2022-09-19 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 14:14 [PATCH v2] commit-graph: Fix missing closedir in expire_commit_graphs Miaoqian Lin
2022-09-19 15:04 ` Derrick Stolee [this message]
2022-09-19 17:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1cf64e-2864-a979-6f75-d9d4148d57da@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=linmq006@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).