From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bsmtp2.bon.at (bsmtp2.bon.at [213.33.87.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C22871E1A3B for ; Fri, 6 Jun 2025 05:57:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.33.87.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749189435; cv=none; b=KGGT1HMnYqiCjnujqwau1BaGuDayWYkvndzRfUNr59rkvuXooWr6ywx5QtBHtHVc7i6Hg6fCW8GyKYXg8gPlJ/WunAk9UPRHtq5jGz66AWPfzig+FHhZ1hDb0kkJYWA9Ah+bkYjKS4TqsZcuLMIaGrOqb5uuKZYrRVNO8IllNJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749189435; c=relaxed/simple; bh=iKwxM1w6bGQaF2K13pId2m/Y/M4PaqzOlNW4M/yTwL0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I3wJJ7ukvJ1ARpzXUc4pa+DRd6c4fVtXFIEjt+k12Y6dAL8uabn13I6wP9pxY1nWbm/kYZCHzkvfqjCPWp+RA8GVGL7CY14FUPVX4mVfLrwh+FGsEw7XH9GJb4zcPDPDuLONlSmoOx7Xd6wkuROEJjsdFkKD4Y1s3bqGUGntp9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kdbg.org; spf=pass smtp.mailfrom=kdbg.org; arc=none smtp.client-ip=213.33.87.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kdbg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kdbg.org Received: from [192.168.0.100] (unknown [93.83.142.38]) by bsmtp2.bon.at (Postfix) with ESMTPSA id 4bD9Z71yrczRpLG; Fri, 6 Jun 2025 07:57:02 +0200 (CEST) Message-ID: <4f390ad8-6c30-493c-952e-d1f079a7f6ac@kdbg.org> Date: Fri, 6 Jun 2025 07:57:02 +0200 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [GIT PULL] git-gui: fix for: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed To: Junio C Hamano Cc: rsbecker@nexbridge.com, 'Patrick Steinhardt' , git@vger.kernel.org, 'Todd Zullinger' References: <007a01dbd4d7$89ebf100$9dc3d300$@nexbridge.com> <007d01dbd4d9$356ded70$a049c850$@nexbridge.com> <44fe8627-5680-443d-bf02-a6e85afd46b4@kdbg.org> <010b01dbd5f1$3c26ec20$b474c460$@nexbridge.com> <014201dbd658$4da75680$e8f60380$@nexbridge.com> Content-Language: en-US From: Johannes Sixt In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The following changes since commit 61f8788fe9d362efb112f69a58cf0510a7e49ee0: Merge branch 'pks-meson-support' of github.com:pks-t/git-gui (2025-05-29 10:01:14 +0200) are available in the Git repository at: https://github.com/j6t/git-gui.git master for you to fetch changes up to 765f1db2b5a890c0fa01f8976f197a8483357afe: git-gui: don't delete source files when auto_mkindex fails (2025-06-06 07:43:37 +0200) ---------------------------------------------------------------- commit 765f1db2b5a890c0fa01f8976f197a8483357afe Author: Johannes Sixt Date: Fri Jun 6 07:41:42 2025 +0200 git-gui: don't delete source files when auto_mkindex fails Commit 2cc5b0facfa4 (git-gui: extract script to generate "tclIndex", 2025-03-11) converted commands in a Makefile rule to a shell script. In this process, the Makefile variable $@ had to be replaced by the file name that it represents, 'lib/tclIndex'. However, the occurrence in `rm -f $@` was missed. In a shell script, $@ expands to all command line arguments, which happen to be the source files lib/*.tcl in this case. Needless to say that we do not want to remove source files during a build. Replace $@ by the intended 'lib/tclIndex'. Reported-by: Randall S. Becker Signed-off-by: Johannes Sixt diff --git a/generate-tclindex.sh b/generate-tclindex.sh index 36e3a0bd90ee..0b031d8339c4 100755 --- a/generate-tclindex.sh +++ b/generate-tclindex.sh @@ -23,7 +23,7 @@ then : ok else echo >&2 " * $TCL_PATH failed; using unoptimized loading" - rm -f $@ + rm -f lib/tclIndex echo '# Autogenerated by git-gui Makefile' >lib/tclIndex echo >>lib/tclIndex echo "class.tcl" >>lib/tclIndex