From: Phillip Wood <phillip.wood123@gmail.com>
To: Thomas Gummerer <t.gummerer@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Rohit Ashiwal <rohit.ashiwal265@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: What's cooking in git.git (Jun 2019, #06; Wed, 26)
Date: Sat, 29 Jun 2019 15:08:16 +0100 [thread overview]
Message-ID: <4f69c62f-f38b-7630-cd8a-ec152a8b6ad0@gmail.com> (raw)
In-Reply-To: <20190628191133.GA15477@hank.intra.tgummerer.com>
On 28/06/2019 20:11, Thomas Gummerer wrote:
> On 06/26, Junio C Hamano wrote:
>> * ra/cherry-pick-revert-skip (2019-06-24) 6 commits
>> - cherry-pick/revert: advise using --skip
>> - cherry-pick/revert: add --skip option
>> - sequencer: use argv_array in reset_merge
>> - sequencer: rename reset_for_rollback to reset_merge
>> - sequencer: add advice for revert
>> - advice: add sequencerInUse config variable
>>
>> "git cherry-pick/revert" learned a new "--skip" action.
>>
>> Is this one ready for 'next'?
>
> Yes, I believe this is ready for 'next'. I had a look at the latest
> round, and only had a minor comment on the organization of the patch
> series that is probably not worth a re-roll.
>
> I also added Phillip to Cc, as he's been heavily involved in reviewing
> this series, in case he has any more comments.
Thanks Thomas. I've just posted a comment [1] about a confusing commit
message and combining two patches but I'm not sure if it's worth a
re-roll or not. The implementation looks fine to me
Best Wishes
Phillip
[1]
https://public-inbox.org/git/5ae3461e-7c83-2eeb-552c-ffe838bb03b6@gmail.com/T/#u
prev parent reply other threads:[~2019-06-29 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 22:29 What's cooking in git.git (Jun 2019, #06; Wed, 26) Junio C Hamano
2019-06-26 22:41 ` Jonathan Tan
2019-06-27 17:11 ` Junio C Hamano
2019-06-27 19:48 ` Matthew DeVore
2019-06-28 2:26 ` Junio C Hamano
2019-06-28 6:24 ` Jeff King
2019-07-01 14:07 ` Barret Rhoden
2019-07-01 16:29 ` Junio C Hamano
2019-07-01 17:55 ` Barret Rhoden
2019-06-28 19:11 ` Thomas Gummerer
2019-06-29 14:08 ` Phillip Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f69c62f-f38b-7630-cd8a-ec152a8b6ad0@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=rohit.ashiwal265@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).