From: Michael Haggerty <mhagger@alum.mit.edu>
To: Michael Schubert <mschub@elegosoft.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] refs: disallow ref components starting with hyphen
Date: Mon, 16 Jul 2012 15:18:24 +0200 [thread overview]
Message-ID: <500414A0.9080802@alum.mit.edu> (raw)
In-Reply-To: <1342440781-18816-2-git-send-email-mschub@elegosoft.com>
On 07/16/2012 02:13 PM, Michael Schubert wrote:
> Currently, we allow refname components to start with a hyphen. There's
> no good reason to do so and it troubles the parseopt infrastructure.
> Explicitly refuse refname components starting with a hyphen inside
> check_refname_component().
Your change to refs.c looks correct. However, you should also update
the documentation of the refname rules at the top of refs.c and also in
Documentation/git-check-ref-format.txt
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2012-07-16 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 12:12 [PATCH] refname format cleanup Michael Schubert
2012-07-16 12:13 ` [PATCH 1/2] refs: disallow ref components starting with hyphen Michael Schubert
2012-07-16 13:18 ` Michael Haggerty [this message]
2012-07-16 17:06 ` Junio C Hamano
2012-07-16 17:49 ` Junio C Hamano
2012-07-16 12:13 ` [PATCH 2/2] symbolic-ref: check format of given refname Michael Schubert
2012-07-16 13:24 ` Michael Haggerty
2012-07-16 17:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500414A0.9080802@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=mschub@elegosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).