From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files
Date: Thu, 19 Jul 2012 09:30:08 +0200 [thread overview]
Message-ID: <5007B780.7010500@gmail.com> (raw)
In-Reply-To: <vpqy5mgdyro.fsf@bauges.imag.fr>
On 07/19/2012 08:56 AM, Matthieu Moy wrote:
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
>
>> for example, an autotools old-timer that has run:
>>
>> ./configure --prefix /opt/git
>>
>> in the past, without running "make distclean" afterwards, would
>> expect a "make install" issued after a "make clean" to rebuild and
>> install git in '/opt/git';
>
> I've been hit by that behavior once. Thanks for fixing it. The patch
> looks good.
>
Should I add "Acked-by: Matthieu Moy" then? (Sorry if it's a dumb
question, but I'm not sure which the preferred policy is around here).
Thanks,
Stefano
next prev parent reply other threads:[~2012-07-19 7:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 22:34 [PATCH 0/7] build system: support automatic reconfiguration for autotools user Stefano Lattarini
2012-07-18 22:34 ` [PATCH 1/7] autoconf: GIT_CONF_APPEND_LINE: change signature Stefano Lattarini
2012-07-18 22:34 ` [PATCH 2/7] autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBST Stefano Lattarini
2012-07-19 0:13 ` Junio C Hamano
2012-07-19 7:32 ` Stefano Lattarini
2012-07-18 22:34 ` [PATCH 3/7] autoconf: remove some redundant shell indirections Stefano Lattarini
2012-07-19 0:29 ` Junio C Hamano
2012-07-19 7:30 ` Stefano Lattarini
2012-07-19 17:24 ` Junio C Hamano
2012-07-19 17:50 ` Stefano Lattarini
2012-07-18 22:34 ` [PATCH 4/7] autoconf: remove few redundant semicolons Stefano Lattarini
2012-07-18 22:35 ` [PATCH 5/7] autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append' Stefano Lattarini
2012-07-18 22:35 ` [PATCH 6/7] build: "make clean" should not remove configure-generated files Stefano Lattarini
2012-07-19 6:56 ` Matthieu Moy
2012-07-19 7:30 ` Stefano Lattarini [this message]
2012-07-19 7:43 ` Matthieu Moy
2012-07-19 7:59 ` Stefano Lattarini
2012-07-19 17:27 ` Junio C Hamano
2012-07-18 22:35 ` [PATCH 7/7] build: reconfigure automatically if configure.ac changes Stefano Lattarini
2012-07-19 0:36 ` [PATCH 0/7] build system: support automatic reconfiguration for autotools user Junio C Hamano
2012-07-19 7:49 ` [PATCH v2 " Stefano Lattarini
2012-07-19 7:49 ` [PATCH v2 1/7] autoconf: GIT_CONF_APPEND_LINE: change signature Stefano Lattarini
2012-07-19 7:49 ` [PATCH v2 2/7] autoconf: GIT_CONF_APPEND_LINE -> GIT_CONF_SUBST Stefano Lattarini
2012-07-19 7:49 ` [PATCH v2 3/7] autoconf: remove some redundant shell indirections Stefano Lattarini
2012-07-19 7:49 ` [PATCH v2 4/7] autoconf: remove few redundant semicolons Stefano Lattarini
2012-07-19 7:50 ` [PATCH v2 5/7] autoconf: use AC_CONFIG_COMMANDS instead of ad-hoc 'config.mak.append' Stefano Lattarini
2012-07-19 7:50 ` [PATCH v2 6/7] build: "make clean" should not remove configure-generated files Stefano Lattarini
2012-07-23 23:15 ` Stefano Lattarini
2012-07-23 23:28 ` Junio C Hamano
2012-07-19 7:50 ` [PATCH v2 7/7] build: reconfigure automatically if configure.ac changes Stefano Lattarini
2012-07-23 23:16 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007B780.7010500@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).