From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Daniel Graña" <dangra@gmail.com>,
git@vger.kernel.org,
"Richard Hartmann" <richih.mailinglist@gmail.com>
Subject: Re: [PATCH] Solve git-submodule issues with detached work trees
Date: Tue, 24 Jul 2012 01:17:45 +0200 [thread overview]
Message-ID: <500DDB99.80103@web.de> (raw)
In-Reply-To: <7vd33mkyhj.fsf@alter.siamese.dyndns.org>
Am 23.07.2012 22:34, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> We could get rid of the core.worktree setting by assuming that the
>> directory a gitfile was found in is the root of the repo's work
>> tree (unless configured otherwise).
>
> Now you lost me. If you have .git that is not a directory but is a
> gitfile, then you do not need GIT_DIR nor GIT_WORK_TREE in the first
> place, no?
Not inside the submodule, me thinks they only make sense in the
superproject (that's why we clean the environment before working
inside the submodule). But setting the superproject's GIT_WORK_TREE
to something else won't work for an already initialized submodule,
as the core.worktree setting will still point to the old work tree
which was set when the submodule was initialized. One could expect
the submodule's work tree to be $GIT_WORK_TREE/$sm_path when
GIT_WORK_TREE is set, but it isn't.
next prev parent reply other threads:[~2012-07-23 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 14:49 [PATCH] Solve git-submodule issues with detached work trees Daniel Graña
2012-07-23 5:09 ` Junio C Hamano
2012-07-23 17:38 ` Jens Lehmann
2012-07-23 18:21 ` Junio C Hamano
2012-07-23 20:02 ` Jens Lehmann
2012-07-23 20:34 ` Junio C Hamano
2012-07-23 23:17 ` Jens Lehmann [this message]
2012-07-23 23:42 ` Junio C Hamano
2012-07-23 18:22 ` Daniel Graña
2012-07-23 18:25 ` Richard Hartmann
2012-07-23 18:27 ` Richard Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500DDB99.80103@web.de \
--to=jens.lehmann@web.de \
--cc=dangra@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=richih.mailinglist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).