From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>,
tboegi@web.de, git@vger.kernel.org
Subject: Re: [PATCH] cleanup precompose_utf8
Date: Sun, 19 Aug 2012 19:10:03 +0200 [thread overview]
Message-ID: <50311DEB.4050700@web.de> (raw)
In-Reply-To: <7vobm9v32e.fsf@alter.siamese.dyndns.org>
On 17.08.12 19:30, Junio C Hamano wrote:
> Robin Rosenberg <robin.rosenberg@dewire.com> writes:
>
>> Remove extraneous parentheses and braces
>> Remove redundant NUL-termination
>> Check result of unlink when probing for decomposed file names
>>
>> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
>> ---
> Thanks. I've found and fixed a bit more style violations while we
> are at it.
(I was offline for a couple of days)
Thanks to all, and ACK from my side.
/Torsten
next prev parent reply other threads:[~2012-08-19 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 13:50 [PATCH v9] git on Mac OS and precomposed unicode Torsten Bögershausen
2012-07-26 20:49 ` Robin Rosenberg
2012-07-26 23:04 ` Junio C Hamano
2012-08-17 3:26 ` Junio C Hamano
2012-08-17 14:53 ` [PATCH] cleanup precompose_utf8 Robin Rosenberg
2012-08-17 17:20 ` Junio C Hamano
2012-08-17 17:30 ` Junio C Hamano
2012-08-19 17:10 ` Torsten Bögershausen [this message]
2012-08-20 18:13 ` [PATCH] precompose-utf8: do not call checks for non-ascii "utf8" Junio C Hamano
2012-08-20 19:46 ` Torsten Bögershausen
2012-08-20 22:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50311DEB.4050700@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).