From: Ross Lagerwall <rosslagerwall@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] difftool: silence warning
Date: Tue, 21 Aug 2012 11:42:14 +0200 [thread overview]
Message-ID: <503357F6.2020907@gmail.com> (raw)
In-Reply-To: <CAJDDKr5W5YJoMEkX7_ax_pvwdibJ81LMzsM0Rnkn1=9=Nu25EA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On 08/21/2012 11:04 AM, David Aguilar wrote:
> This patch is obviously correct, but it won't apply in git's "next" branch.
> Can you please prepare a patch based on the version in next?
>
Sure.
>
> A small question on Perl style for the list... is it better say this?
>
> exit(0) unless $diffrtn;
>
> or is it better to explicitly check for undef using defined($diffrtn)
> like was done in this patch? I would assume that explicit is preferred.
>
It seems like defined() is used throughout git-difftool so I just used that.
Regards
--
Ross Lagerwall
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-08-21 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 6:59 [PATCH] difftool: silence warning Ross Lagerwall
2012-08-21 9:04 ` David Aguilar
2012-08-21 9:42 ` Ross Lagerwall [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-21 10:21 Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503357F6.2020907@gmail.com \
--to=rosslagerwall@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).