git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Brandon Casey <drafnel@gmail.com>
Cc: Joachim Schmitz <jojo@schmitz-digital.de>,
	Junio C Hamano <gitster@pobox.com>,
	Shawn Pearce <spearce@spearce.org>,
	git@vger.kernel.org, rsbecker@nexbridge.com
Subject: Re: Porting git to HP NonStop
Date: Wed, 22 Aug 2012 19:41:07 +0200	[thread overview]
Message-ID: <503519B3.1020403@kdbg.org> (raw)
In-Reply-To: <CA+sFfMdnixrUekh40Sde05tkap7Oj19=5D6J6aYVVD1krqPZkw@mail.gmail.com>

Am 22.08.2012 19:00, schrieb Brandon Casey:
>  So I think the body of [compat_mkdir] can become
> something like:
> 
>    if (len && dir[len-1] == '/')
>        dir = tmp_dir = xstrndup(dir, len-1);

Don't use x* wrappers in the compat layer, at least not those that
allocate memory: They behave unpredictably due to try_to_free_routine
and may lead to recursive invocations.

> 
>    retval = mkdir(dir, mode);
>    free(tmp_dir);

-- Hannes

  parent reply	other threads:[~2012-08-22 17:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 15:04 Porting git to HP NonStop Joachim Schmitz
2012-08-10 16:27 ` Shawn Pearce
2012-08-10 17:32   ` Joachim Schmitz
2012-08-10 17:38     ` Shawn Pearce
2012-08-19  8:57       ` Joachim Schmitz
2012-08-19 17:23         ` Junio C Hamano
2012-08-20 10:22           ` Joachim Schmitz
2012-08-20 14:41             ` Junio C Hamano
2012-08-20 16:09               ` Joachim Schmitz
2012-08-20 16:53                 ` Junio C Hamano
2012-08-22 16:30                   ` Joachim Schmitz
2012-08-22 17:00                     ` Brandon Casey
2012-08-22 17:13                       ` Brandon Casey
2012-08-22 17:18                       ` Joachim Schmitz
2012-08-22 17:23                         ` Brandon Casey
2012-08-22 17:30                           ` Joachim Schmitz
2012-08-22 17:30                       ` Junio C Hamano
2012-08-22 18:01                         ` Joachim Schmitz
2012-08-22 18:24                           ` Junio C Hamano
2012-08-22 18:52                             ` Joachim Schmitz
2012-08-22 17:41                       ` Johannes Sixt [this message]
2012-08-22 18:02                         ` Joachim Schmitz
2012-08-22 18:09                           ` Johannes Sixt
2012-08-22 18:18                             ` Joachim Schmitz
2012-08-22 18:09                         ` Brandon Casey
2012-08-22 18:24                           ` Brandon Casey
2012-08-22 18:33                             ` Junio C Hamano
2012-08-22 18:38                               ` Brandon Casey
2012-08-22 20:18                                 ` Joachim Schmitz
2012-08-22 20:49                                   ` Junio C Hamano
2012-08-22 21:05                                     ` Joachim Schmitz
2012-08-22 21:12                                       ` Junio C Hamano
2012-08-22 21:22                                         ` Joachim Schmitz
2012-08-22 21:54                                           ` Junio C Hamano
2012-08-22 18:26                           ` Junio C Hamano
2012-08-10 20:08   ` Joachim Schmitz
2012-08-11  8:20   ` Johannes Sixt
2012-08-14  7:05   ` Joachim Schmitz
2012-08-14 14:56     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503519B3.1020403@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jojo@schmitz-digital.de \
    --cc=rsbecker@nexbridge.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).