git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Caron <Matt.Caron@redlion.net>
To: <git@vger.kernel.org>
Subject: I think git show is broken
Date: Tue, 28 Aug 2012 13:38:51 -0400	[thread overview]
Message-ID: <503D022B.6070001@redlion.net> (raw)

(otherwise, there was a very strange change made to its functionality, 
which the documentation does not reflect)


Old, working git:

===
$ git --version
git version 1.7.0.4
$ git show --quiet --abbrev-commit --pretty=oneline 
47a7aee54553fb718c376cfa9d7de4389a391e33
47a7aee Fix hyperlinks for dependent tickets (#7139, #4976).
===

New, "broken" git:

===
$ git --version
git version 1.7.9.5

$ git show --quiet --abbrev-commit --pretty=oneline 
47a7aee54553fb718c376cfa9d7de4389a391e33
47a7aee Fix hyperlinks for dependent tickets (#7139, #4976).
diff --git a/mastertickets/web_ui.py b/mastertickets/web_ui.py
index a91b862..698ed98 100644
--- a/mastertickets/web_ui.py
+++ b/mastertickets/web_ui.py
@@ -32,7 +32,7 @@ class MasterTicketsModule(Component):
      use_gs = BoolOption('mastertickets', 'use_gs', default=False,
                          doc='If enabled, use ghostscript to produce 
nicer output.')

-    FIELD_XPATH = 
'div[@id="ticket"]/table[@class="properties"]/td[@headers="h_%s"]/text()'
+    FIELD_XPATH = 
'.//div[@id="ticket"]/table[@class="properties"]//td[@headers="h_%s"]/text()'
      fields = set(['blocking', 'blockedby'])

      # IRequestFilter methods
===

It appears as though the new functionality always puts out a "medium" 
verbosity diff. Though the manpage says that it honors pretty=oneline, 
it does not seem to.

I searched around the message logs, etc. and would have expected this 
change to have thrown everyone else into as much upheaval as it has in 
my organization, and found nothing. Am I missing something?

Thanks in advance.
-- 
Matthew Caron, Software Build Engineer
Sixnet, a Red Lion business | www.sixnet.com
+1 (518) 877-5173 x138 office

             reply	other threads:[~2012-08-28 17:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 17:38 Matthew Caron [this message]
2012-08-28 17:48 ` I think git show is broken Matthew Caron
2012-08-28 21:29   ` Jeff King
2012-08-28 22:36     ` Junio C Hamano
2012-08-28 22:45       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503D022B.6070001@redlion.net \
    --to=matt.caron@redlion.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).