From: Johannes Sixt <j6t@kdbg.org>
To: Joachim Schmitz <jojo@schmitz-digital.de>
Cc: 'Junio C Hamano' <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it
Date: Mon, 03 Sep 2012 20:15:55 +0200 [thread overview]
Message-ID: <5044F3DB.9060908@kdbg.org> (raw)
In-Reply-To: <000d01cd89b6$d5ba6c30$812f4490$@schmitz-digital.de>
Am 03.09.2012 11:31, schrieb Joachim Schmitz:
>
> Hmm, I see that there the errors are handled differently, like this:
>
> if (ovalue != NULL)
> return errno = EINVAL,
> error("setitimer param 3 != NULL not implemented");
>
> Should this be done in my setitimer() too? Or rather be left to the caller?
> I tend to the later.
The error message is really just a reminder that the implementation is
not complete. Writing it here has the advantage that it is much more
accurate than a generic "invalid argument" or "operation not supported"
error that the caller would be able to write.
-- Hannes
next prev parent reply other threads:[~2012-09-03 18:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 10:39 [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz
2012-08-28 20:15 ` Junio C Hamano
2012-08-30 16:40 ` Joachim Schmitz
2012-08-30 17:13 ` Junio C Hamano
2012-08-30 17:22 ` Joachim Schmitz
2012-09-01 9:50 ` Joachim Schmitz
2012-09-02 20:43 ` Junio C Hamano
2012-09-03 9:31 ` Joachim Schmitz
2012-09-03 18:15 ` Johannes Sixt [this message]
2012-09-03 18:57 ` Junio C Hamano
2012-09-03 19:03 ` Junio C Hamano
2012-09-03 20:05 ` Joachim Schmitz
2012-09-04 16:58 ` Junio C Hamano
2012-09-04 17:23 ` Joachim Schmitz
2012-09-04 18:28 ` Junio C Hamano
2012-09-04 18:47 ` Junio C Hamano
2012-09-04 21:47 ` Joachim Schmitz
2012-09-04 22:44 ` Junio C Hamano
2012-09-05 9:59 ` Joachim Schmitz
2012-09-04 18:48 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044F3DB.9060908@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojo@schmitz-digital.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).