From: Paolo Bonzini <bonzini@gnu.org>
To: Joachim Schmitz <jojo@schmitz-digital.de>
Cc: git@vger.kernel.org, 'Junio C Hamano' <gitster@pobox.com>,
'Erik Faye-Lund' <kusmabite@gmail.com>,
bug-gnulib@gnu.org, rsbecker@nexbridge.com
Subject: Re: poll() emulation in git
Date: Thu, 06 Sep 2012 17:15:02 +0200 [thread overview]
Message-ID: <5048BDF6.2000602@gnu.org> (raw)
In-Reply-To: <010a01cd8c3e$25609500$7021bf00$@schmitz-digital.de>
Il 06/09/2012 16:44, Joachim Schmitz ha scritto:
>> > Yes, it's an usleep(autocorrect * 100000) basically (poll takes
>> > milliseconds, not micro).
> OK, it is _supposed_ to do this usleep(), but is does not, as poll() returns early with EFAULT in this case:
> /* EFAULT is not necessary to implement, but let's do it in the
> simplest case. */
> if (!pfd)
> {
> errno = EFAULT;
> return -1;
> }
>
> poll() is doing this before calling select(), so won't sleep.
> So there's a bug in {gnulib|git}'s poll(), right?
>
Yes, it should be "if (!pfd && nfd)".
Paolo
next prev parent reply other threads:[~2012-09-06 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:24 poll() emulation in git Joachim Schmitz
2012-09-05 11:55 ` Bastien ROUCARIES
2012-09-05 12:04 ` Joachim Schmitz
2012-09-05 12:05 ` Paolo Bonzini
2012-09-05 12:57 ` Joachim Schmitz
2012-09-05 13:36 ` Joachim Schmitz
2012-09-05 15:25 ` Paolo Bonzini
2012-09-06 14:02 ` Joachim Schmitz
2012-09-06 14:31 ` Paolo Bonzini
2012-09-06 14:44 ` Joachim Schmitz
2012-09-06 15:15 ` Paolo Bonzini [this message]
2012-09-07 7:23 ` Joachim Schmitz
2012-09-07 7:39 ` Joachim Schmitz
2012-09-07 9:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5048BDF6.2000602@gnu.org \
--to=bonzini@gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojo@schmitz-digital.de \
--cc=kusmabite@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).