From: Jan-Marek Glogowski <glogow@fbihome.de>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Prefix shell test output messages with test id
Date: Thu, 06 Sep 2012 22:29:38 +0200 [thread overview]
Message-ID: <504907B2.7060704@fbihome.de> (raw)
In-Reply-To: <20120906123400.GA25467@tommy-fedora.scientificnet.net>
Am 06.09.2012 14:34, schrieb Thomas Gummerer:
> On 09/06, Jan-Marek Glogowski wrote:
>> This adds the test ID (tXXXX) prefix to the test result message of
>> all shell tests. This is especially useful when doing a parallel
>> check run, where it's currently quite hard to identify the actual
>> failing test case.
>>
>> Signed-off-by: Jan-Marek Glogowski <glogow@fbihome.de>
>
> This breaks the TAP output format of the tests, which is needed to run
> them with prove. To identify the failing tests more easily when running
> the tests in parallel, you may want to add GIT_TEST_TARGET = prove to
> your config.mak.
>
> If this change is really needed, I think you should add the test-id after
> the message.
While grep'ing for prove I found t/README...
>From my point of view the patch can be dropped. I can set GIT_PROVE_OPTS
to run prove with multiple CPUS. Is there a known (easy) way to
propagate MAKEFLAGS -j to prove?
And I would like to propose a symlink from Documentation/testing =>
../t/README.
Thanks for the quick review.
prev parent reply other threads:[~2012-09-06 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 11:45 [PATCH] Prefix shell test output messages with test id Jan-Marek Glogowski
2012-09-06 12:34 ` Thomas Gummerer
2012-09-06 15:10 ` Jeff King
2012-09-06 20:29 ` Jan-Marek Glogowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504907B2.7060704@fbihome.de \
--to=glogow@fbihome.de \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).