git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: What's cooking in git.git (Sep 2012, #02; Fri, 7)
Date: Sat, 08 Sep 2012 07:47:22 +0200	[thread overview]
Message-ID: <504ADBEA.1050606@web.de> (raw)
In-Reply-To: <7vy5klv6oj.fsf@alter.siamese.dyndns.org>

On 07.09.12 23:55, Junio C Hamano wrote:
> [Discarded]
> 
> * jc/sanitize-nkd-lazy-iconv-open (2012-07-31) 1 commit
>  . macos: lazily initialize iconv
> 
> Teach the code that works around NKD/NKC gotcha on MacOS to call
> iconv_open() only when it is necessary, in the hope of avoiding
> set-up overhead.  It turns out that there was no noticeable
> improvements.

My vote is not to discard the branch: 

Even if the improvements are not measurable, the lazy iconv_open
is a good coding style.

It might inspire people to use resources carefully, 
and only allocate them if they are really needed.

      reply	other threads:[~2012-09-08  5:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 21:55 What's cooking in git.git (Sep 2012, #02; Fri, 7) Junio C Hamano
2012-09-08  5:47 ` Torsten Bögershausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504ADBEA.1050606@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).