From: Johannes Sixt <j6t@kdbg.org>
To: Ralf Thielow <ralf.thielow@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH/RFC] blame: respect "core.ignorecase"
Date: Sun, 09 Sep 2012 21:03:14 +0200 [thread overview]
Message-ID: <504CE7F2.9010306@kdbg.org> (raw)
In-Reply-To: <1347210113-27435-1-git-send-email-ralf.thielow@gmail.com>
Am 09.09.2012 19:01, schrieb Ralf Thielow:
> If "core.ignorecase" is true, "git blame" fails
> when the given path differs to the real path in case
> sensitivity.
...
> + dir = opendir(res.buf);
...
> + struct dirent *ent = readdir(dir);
...
> + if (!strcasecmp(p.buf, ent->d_name)) {
I don't think this is how core.ignorecase is intended to work. It does
not trigger case-insensitive lookup in the worktree (this is still done
by the OS), but it does a case-insensitive lookup in the index. That is,
given a worktree entry 'readme', it allows to find the index entry 'README'.
IMO, it is only correct that 'git blame file' operates on 'FILE' if
'FILE' exists in the index, and in only that case, it does not matter
how the 'file' is named in the worktree.
-- Hannes
next prev parent reply other threads:[~2012-09-09 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 17:01 [PATCH/RFC] blame: respect "core.ignorecase" Ralf Thielow
2012-09-09 19:03 ` Johannes Sixt [this message]
2012-09-09 19:24 ` Junio C Hamano
2012-09-09 19:45 ` Junio C Hamano
2012-09-11 21:44 ` [PATCH] blame: allow "blame file" in the middle of a conflicted merge Junio C Hamano
2012-09-10 5:57 ` [PATCH/RFC] blame: respect "core.ignorecase" Ralf Thielow
2012-09-10 16:13 ` Jeff King
2012-09-10 20:30 ` Junio C Hamano
2012-09-10 20:34 ` Jeff King
2012-09-10 21:38 ` Junio C Hamano
2012-09-10 21:41 ` Jeff King
2012-09-10 23:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504CE7F2.9010306@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ralf.thielow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).