From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/6] string_list: add function string_list_append_nodup()
Date: Tue, 11 Sep 2012 00:03:29 +0200 [thread overview]
Message-ID: <504E63B1.2070100@alum.mit.edu> (raw)
In-Reply-To: <7vpq5tleyo.fsf@alter.siamese.dyndns.org>
On 09/10/2012 11:56 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> diff --git a/string-list.c b/string-list.c
>> index d9810ab..5594b7d 100644
>> --- a/string-list.c
>> +++ b/string-list.c
>> @@ -148,13 +148,23 @@ void print_string_list(const struct string_list *p, const char *text)
>> printf("%s:%p\n", p->items[i].string, p->items[i].util);
>> }
>>
>> -struct string_list_item *string_list_append(struct string_list *list, const char *string)
>> +struct string_list_item *string_list_append_nodup(struct string_list *list,
>> + char *string)
>> {
>> + struct string_list_item *retval;
>> ALLOC_GROW(list->items, list->nr + 1, list->alloc);
>> - list->items[list->nr].string =
>> - list->strdup_strings ? xstrdup(string) : (char *)string;
>> - list->items[list->nr].util = NULL;
>> - return list->items + list->nr++;
>> + retval = &list->items[list->nr++];
>> + retval->string = (char *)string;
>
> Do you still need this cast, now the function takes non-const "char *string"?
Good catch. Do you want to fix this in your repo or should I re-roll?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2012-09-10 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 21:18 [PATCH v2 0/6] Add some string_list-related functions Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 1/6] string_list: add function string_list_append_nodup() Michael Haggerty
2012-09-10 21:56 ` Junio C Hamano
2012-09-10 22:03 ` Michael Haggerty [this message]
2012-09-12 13:32 ` Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 2/6] string_list: add two new functions for splitting strings Michael Haggerty
2012-09-10 22:00 ` Junio C Hamano
2012-09-10 22:33 ` Junio C Hamano
2012-09-12 13:12 ` Michael Haggerty
2012-09-12 17:55 ` Junio C Hamano
2012-09-10 21:18 ` [PATCH v2 3/6] string_list: add a new function, filter_string_list() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 4/6] string_list: add a new function, string_list_remove_duplicates() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 5/6] string_list: add a function string_list_longest_prefix() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 6/6] api-string-list.txt: initialize the string_list the easy way Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E63B1.2070100@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).