git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Oberndorfer <kumbayo84@arcor.de>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: Synchronize highlighting in file view when scrolling diff
Date: Tue, 18 Sep 2012 20:23:49 +0200	[thread overview]
Message-ID: <5058BC35.6050007@arcor.de> (raw)
In-Reply-To: <1347947874-38597-1-git-send-email-stefan@haller-berlin.de>

On 2012-09-18 07:57, Stefan Haller wrote:
> Whenever the diff pane scrolls, highlight the corresponding file in the
> file list on the right. For a large commit with many files and long
> per-file diffs, this makes it easier to keep track of what you're looking
> at.

Hi,
i like this function!
I have often lost track which file i am currently looking at.
Especially with long files.

But i noticed following minor thing:
When selecting a new commit, for a split second the first file name is selected
and then the "Comments" entry is selected.
The flickering is more visible when you hold down the mouse on the up/down button
of the "Lines of code" field.

Can this flickering be avoided?

Thanks,
Greetings Peter

> This allows simplifying the prevfile and nextfile functions, because
> all they have to do is scroll the diff pane.
>
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>
> ---
>   gitk | 27 ++++++++++++++++-----------
>   1 file changed, 16 insertions(+), 11 deletions(-)
>
>

  reply	other threads:[~2012-09-18 18:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  5:57 [PATCH] gitk: Synchronize highlighting in file view when scrolling diff Stefan Haller
2012-09-18 18:23 ` Peter Oberndorfer [this message]
2012-09-19  9:57   ` [PATCH v2] " Stefan Haller
2012-09-18 23:46 ` [PATCH] " Paul Mackerras
2012-09-19 14:28   ` Marc Branchaud
2012-09-19 18:17   ` [PATCH v3] " Stefan Haller
2012-09-23  6:58     ` Paul Mackerras
2012-09-24  5:51       ` Stefan Haller
2012-10-26 22:03     ` [PATCH] gitk: Do not select file list entries during diff loading Peter Oberndorfer
2012-10-29  8:56       ` Stefan Haller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5058BC35.6050007@arcor.de \
    --to=kumbayo84@arcor.de \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=stefan@haller-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).