From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Adam Spiers <git@adamspiers.org>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] Make test output coloring more intuitive
Date: Wed, 19 Sep 2012 22:02:52 +0200 [thread overview]
Message-ID: <505A24EC.1000203@gmail.com> (raw)
In-Reply-To: <20120917201119.GB24888@sigill.intra.peff.net>
On 09/17/2012 10:11 PM, Jeff King wrote:
> On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote:
>
>> The end result of these changes is that:
>>
>> - red is _only_ used for things which have gone unexpectedly wrong:
>> test failures, unexpected test passes, and failures with the
>> framework,
>>
>> - yellow is _only_ used for known breakages, and
>>
>> - green is _only_ used for things which have gone to plan and
>> require no further work to be done.
>
> Sounds reasonable, and I think the new output looks nice. I notice that
> skipped tests are still in green. I wonder if they should be in yellow,
> too.
>
What about blue instead? This would keep the colouring scheme more
consistent with the one used by prove:
<http://search.cpan.org/~ovid/Test-Harness/bin/prove>
by autotest:
<http://www.gnu.org/software/autoconf/manual/autoconf.html#Using-Autotest>
and by the Automake-generated test harness:
<http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites>
Just my 2 cents,
Stefano
next prev parent reply other threads:[~2012-09-19 20:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 11:50 [PATCH] Make test output coloring more intuitive Adam Spiers
2012-09-17 20:11 ` Jeff King
2012-09-18 21:21 ` Adam Spiers
2012-09-19 20:02 ` Stefano Lattarini [this message]
2012-09-19 20:12 ` Adam Spiers
2012-09-19 20:13 ` Jeff King
2012-09-19 20:24 ` [PATCH v4 3/6] Color skipped tests blue Adam Spiers
2012-09-20 5:48 ` Johannes Sixt
2012-09-20 9:04 ` Adam Spiers
2012-09-20 9:08 ` [PATCH v5 3/3] Color skipped tests bold blue Adam Spiers
2012-09-20 10:08 ` Stefano Lattarini
2012-09-20 16:20 ` Junio C Hamano
2012-09-21 6:13 ` [PATCH v4 3/6] Color skipped tests blue Jeff King
2012-11-11 2:04 ` Adam Spiers
2012-09-17 20:50 ` [PATCH] Make test output coloring more intuitive Junio C Hamano
2012-09-18 21:36 ` Adam Spiers
2012-09-18 21:59 ` Jeff King
2012-09-18 22:14 ` Adam Spiers
2012-09-19 17:15 ` [PATCH v2 0/6] make " Adam Spiers
2012-09-19 17:15 ` [PATCH v2 1/6] Change the color of individual known breakages Adam Spiers
2012-09-19 17:15 ` [PATCH v2 2/6] Make 'not ok $count - $message' consistent with 'ok $count - $message' Adam Spiers
2012-09-19 17:50 ` Jeff King
2012-09-19 23:39 ` Junio C Hamano
2012-09-19 23:45 ` Adam Spiers
2012-09-19 17:15 ` [PATCH v2 3/6] Color skipped tests the same as informational messages Adam Spiers
2012-09-19 17:15 ` [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib Adam Spiers
2012-09-19 17:56 ` Jeff King
2012-09-19 18:44 ` Adam Spiers
2012-09-19 18:49 ` [PATCH v3 " Adam Spiers
2012-09-19 18:49 ` [PATCH v3 5/6] Test the test framework more thoroughly Adam Spiers
2012-09-19 18:49 ` [PATCH v3 6/6] Treat unexpectedly fixed known breakages more seriously Adam Spiers
2012-09-20 21:13 ` [PATCH v3 4/6] Refactor mechanics of testing in a sub test-lib Junio C Hamano
2012-09-19 19:37 ` [PATCH v2 " Jeff King
2012-09-19 20:15 ` Adam Spiers
2012-09-19 17:15 ` [PATCH v2 5/6] Test the test framework more thoroughly Adam Spiers
2012-09-19 17:15 ` [PATCH v2 6/6] Treat unexpectedly fixed known breakages more seriously Adam Spiers
2012-09-19 18:05 ` [PATCH v2 0/6] make test output coloring more intuitive Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505A24EC.1000203@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).