From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/7] grep.c: mark private file-scope symbols as static
Date: Thu, 20 Sep 2012 21:43:16 +0100 [thread overview]
Message-ID: <505B7FE4.1050706@ramsay1.demon.co.uk> (raw)
In-Reply-To: <7vfw6dg2q6.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>> Heh, so I obviously didn't see this before sending the patch yesterday! :-D
>>
>> Yes, this solves the problem addressed by yesterday's patch, so please
>> ignore that. However, this tickles sparse to complain as well ... ;-)
>>
>> New patch on it's way.
>
> Are you sure the patch you are responding to really "tickles
> sparse"?
Yes.
> You have another grep.c patch timestamped two minutes after the
> message I am responding to, and as far as I can see, it is a subset
> of the patch you are responding to with the message I am responding
> to.
Hmm, that sentence has too many twists for me! :-D
Let me see if I can clear up the misunderstanding:
- the "patch from yesterday" (18-09-2021) fixed a complaint from
sparse regarding symbol 'dump_grep_expression'. This was before
I had seen this patch email, or the resulting commit 07a7d656.
Since my "patch from yesterday" is a strict subset of your patch,
then your patch also fixes the complaint from sparse regarding
the 'dump_grep_expression' symbol.
- this patch (commit 07a7d656) causes sparse to complain about the
symbols 'grep_source_load' and 'grep_source_is_binary'. The new
patch from me ("timestamped two minutes after ...") also titled
"grep.c: Fix some sparse warnings" on 19-09-2012 at 7:04 PM, is
*not* a subset of commit 07a7d656. This patch addresses the new
sparse warnings regarding 'grep_source_load' and
'grep_source_is_binary'.
Hopefully that addresses the confusion! ;-)
HTH
ATB,
Ramsay Jones
next prev parent reply other threads:[~2012-09-20 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 16:18 [PATCH] test-string-list.c: Fix some sparse warnings Ramsay Jones
2012-09-15 20:52 ` Junio C Hamano
2012-09-15 21:10 ` [PATCH 1/7] builtin/notes.c: mark file-scope functions as static Junio C Hamano
2012-09-15 21:10 ` [PATCH 2/7] commit.c: " Junio C Hamano
2012-09-15 21:10 ` [PATCH 3/7] diff.c: mark private file-scope symbols " Junio C Hamano
2012-09-15 21:10 ` [PATCH 4/7] graph.c: " Junio C Hamano
2012-09-15 21:10 ` [PATCH 5/7] grep.c: " Junio C Hamano
2012-09-19 18:02 ` Ramsay Jones
2012-09-19 20:46 ` Junio C Hamano
2012-09-20 20:43 ` Ramsay Jones [this message]
2012-09-15 21:10 ` [PATCH 6/7] rerere.c: " Junio C Hamano
2012-09-15 21:10 ` [PATCH 7/7] notes.c: " Junio C Hamano
2012-09-17 8:15 ` [PATCH] test-string-list.c: Fix some sparse warnings Michael Haggerty
2012-09-19 19:07 ` Ramsay Jones
2012-09-20 7:13 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B7FE4.1050706@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).