From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Orgad Shaneh <orgads@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] commit: configure submodules
Date: Mon, 24 Sep 2012 20:15:09 +0200 [thread overview]
Message-ID: <5060A32D.1060902@web.de> (raw)
In-Reply-To: <7v39271j3n.fsf@alter.siamese.dyndns.org>
Am 24.09.2012 18:27, schrieb Junio C Hamano:
> Junio C Hamano <gitster@pobox.com> writes:
>> In any case, the log message I suggested in the review needs to be
>> updated in the reroll to make it clear that this is about reading
>> from .gitmodules, not "configuration". AFAICS, gitmodule_config()
>> does not even read from $GIT_DIR/config, right?
>
> OK. gitmodule_config() does not read $GIT_DIR/config, but
> cmd_status() and cmd_commit() call git_diff_basic_config() that is
> called from git_diff_ui_config() to read submodule.$name.ignore from
> it. So Orgad's patch is _only_ about submodule.$name.ignore that is
> in in-tree .gitmodule; the log message shouldn't mention "config",
> as setting configuration variables work for both status and commit
> just fine.
Yes, I was just checking that call path too to make sure the user
settings from $GIT_DIR/config really override those found in
.gitmodules. And of course you are right, while the change to the
code is sane the commit message still needs some work.
next prev parent reply other threads:[~2012-09-24 18:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 7:37 [PATCH] commit: configure submodules Orgad Shaneh
2012-09-23 8:37 ` Junio C Hamano
2012-09-23 18:13 ` Jens Lehmann
2012-09-24 5:57 ` Junio C Hamano
2012-09-24 16:27 ` Junio C Hamano
2012-09-24 18:15 ` Jens Lehmann [this message]
2012-09-24 18:34 ` Junio C Hamano
2012-09-24 18:49 ` Orgad Shaneh
2012-09-24 19:06 ` Junio C Hamano
2012-09-24 19:16 ` Orgad Shaneh
2012-09-24 19:56 ` Jens Lehmann
2012-09-24 19:59 ` Orgad Shaneh
2012-09-24 20:10 ` Jens Lehmann
2012-09-24 20:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060A32D.1060902@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).