From: Jens Lehmann <Jens.Lehmann@web.de>
To: Orgad Shaneh <orgads@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] submodule: configure submodule.<name>.path on add and init
Date: Mon, 24 Sep 2012 21:57:49 +0200 [thread overview]
Message-ID: <5060BB3D.9010609@web.de> (raw)
In-Reply-To: <1348515040-19986-1-git-send-email-orgads@gmail.com>
Am 24.09.2012 21:30, schrieb Orgad Shaneh:
> In order to read diff options for a submodule, its path must be configured
> ---
> git-submodule.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 3e2045e..f97bb62 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -359,6 +359,7 @@ Use -f if you really want to add it." >&2
> esac
> ) || die "$(eval_gettext "Unable to checkout submodule '\$sm_path'")"
> fi
> + git config submodule."$sm_path".path "$sm_path"
> git config submodule."$sm_path".url "$realrepo"
>
> git add $force "$sm_path" ||
> @@ -476,6 +477,7 @@ cmd_init()
> url=$(resolve_relative_url "$url") || exit
> ;;
> esac
> + git config submodule."$name".path "$name" ||
> git config submodule."$name".url "$url" ||
> die "$(eval_gettext "Failed to register url for submodule path '\$sm_path'")"
Nack. The path must only be configured in .gitmodules or we'll
never be able to rename the submodule directory.
next prev parent reply other threads:[~2012-09-24 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 19:30 [PATCH] submodule: configure submodule.<name>.path on add and init Orgad Shaneh
2012-09-24 19:32 ` Orgad Shaneh
2012-09-24 19:57 ` Jens Lehmann [this message]
2012-09-24 20:43 ` Junio C Hamano
2012-09-25 20:58 ` Jens Lehmann
-- strict thread matches above, loose matches on Subject: below --
2012-09-24 19:32 Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060BB3D.9010609@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).