From: Jens Lehmann <Jens.Lehmann@web.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Marc Branchaud <marcnarc@xiplink.com>
Subject: Re: [PATCH] submodule: use abbreviated sha1 in 'status' output
Date: Sat, 29 Sep 2012 17:05:29 +0200 [thread overview]
Message-ID: <50670E39.8080101@web.de> (raw)
In-Reply-To: <CALkWK0kzZvPv9jFBF=ibMzcNt-jxq4RFjy7pL173+Y4_S0jhWA@mail.gmail.com>
Am 29.09.2012 16:45, schrieb Ramkumar Ramachandra:
> Jens Lehmann wrote:
>> I'm not against the change per se, but do we really want to risk breaking
>> scripts which parse the output of "git submodule status" without even
>> providing a commit message explaining why we did that?
>
> Oh, I didn't realize that there might be such scripts. What
> justification do I give in the commit message apart from
> prettification?
Is a prettification justification enough to break backwards compatibility
and to risk breaking scripts and user expectations? I think we must have
a really good reasons to do that, and just making stuff prettier doesn't
count for me unless we have a strong user demand for that.
I suspect you got the idea for this patch from Marc's recent comment:
Am 24.09.2012 17:07, schrieb Marc Branchaud:
> (Honestly, submodule's status sub-command has always felt more like plumbing
> to me than something a user would work with directly. Maybe it's just the
> full-length SHA's that put me off...)
That is just a single user so far indicating your patch /could/ be an
improvement. I think we need quite some more votes on that before we
should do a change like this.
next prev parent reply other threads:[~2012-09-29 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 13:43 [PATCH] submodule: make 'show' an alias for 'summary' Ramkumar Ramachandra
2012-09-29 13:43 ` [PATCH] submodule: use abbreviated sha1 in 'status' output Ramkumar Ramachandra
2012-09-29 14:31 ` Jens Lehmann
2012-09-29 14:45 ` Ramkumar Ramachandra
2012-09-29 15:05 ` Jens Lehmann [this message]
2012-10-01 6:42 ` Ramkumar Ramachandra
2012-10-01 17:22 ` Jens Lehmann
2012-09-29 14:49 ` [PATCH] submodule: make 'show' an alias for 'summary' Jens Lehmann
2012-09-29 15:07 ` Ramkumar Ramachandra
2012-09-29 15:27 ` Jens Lehmann
2012-10-01 6:45 ` Ramkumar Ramachandra
2012-10-01 17:26 ` Jens Lehmann
2012-10-01 17:33 ` Ramkumar Ramachandra
2012-10-01 19:31 ` Jens Lehmann
2012-10-01 17:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50670E39.8080101@web.de \
--to=jens.lehmann@web.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).