From: Michael Haggerty <mhagger@alum.mit.edu>
To: Christopher Rorvick <chris@rorvick.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-cvsimport: support local timezone
Date: Fri, 12 Oct 2012 09:57:54 +0200 [thread overview]
Message-ID: <5077CD82.6000405@alum.mit.edu> (raw)
In-Reply-To: <CAEUsAPYaYGDHWkixf9U27_Hsa7QqCWq3csKtBH7MrjnMD6kKJQ@mail.gmail.com>
On 10/12/2012 02:14 AM, Christopher Rorvick wrote:
> On Thu, Oct 11, 2012 at 5:43 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>> On 10/11/2012 10:48 PM, Chris Rorvick wrote:
>>> CVS patches are unconditionally imported with a UTC timezone. Allow
>>> the local timezone by adding -l to the command line or specifying
>>> cvsimport.l in the config.
>>>
>>> This could be made the default behavior, as setting TZ=UTC in the
>>> environment before doing the import is equivalent to the current
>>> behavior. But since a new default may be an unwelcome surprise to
>>> some, make this new behavior available os an option.
>>
>> According to rcsfile(7), all times in RCS/CVS files are recorded in UTC.
>> So why do you need this feature?
>
> [...]
> Likewise, just because the RCS file has a UTC timestamp does not mean
> the commit originated in Greenwich, UK. Git includes the timezone
> offset in its timestamps, so it is reasonable to allow me to specify
> what is appropriate.
Ahh, OK, I hadn't realized that git stores (UTC time + time zone). I
mistakenly thought you wanted to use a time zone to transform CVS-time
to git-time, i.e., as if the CVS time were recorded in local time. Your
actual goal makes sense.
[And it is something I should consider building into cvs2git.]
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2012-10-12 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 20:48 [PATCH] git-cvsimport: support local timezone Chris Rorvick
2012-10-11 22:43 ` Michael Haggerty
2012-10-12 0:14 ` Christopher Rorvick
2012-10-12 7:57 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077CD82.6000405@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=chris@rorvick.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).