From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jeff King <peff@peff.net>
Cc: Eric Blake <eblake@redhat.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] notes: mention --notes in more places
Date: Thu, 18 Oct 2012 14:11:57 +0200 [thread overview]
Message-ID: <507FF20D.6030106@drmicha.warpmail.net> (raw)
In-Reply-To: <20121017190507.GA17648@sigill.intra.peff.net>
Jeff King venit, vidit, dixit 17.10.2012 21:05:
> On Wed, Oct 17, 2012 at 07:30:56AM -0600, Eric Blake wrote:
>
>>> We've talked about it several times, but it's never happened (probably
>>> because most people don't actually use notes).
>>
>> And people (like me) don't use notes because they aren't documented.
>> Catch-22, so we have to start somewhere.
>
> Oh, I definitely agree your patch is the right direction. I was just
> explaining why it hasn't happened, even though people think it's a good
> idea.
>
>> I'll submit a v2 with the non-controversial edits, and spend some time
>> trying to figure out how to isolate the portion of pretty-options.txt
>> that is relevant to format-patch. If it's easy enough, I can also
>> consider using --- instead of Notes: as the separator when using
>> format-patch.
>
> Hmm. After digging in the archive, it seems we (including both you and
> me!) have discussed this several times, and there are even some patches
> floating around. Maybe one of them would be a good starting point for
> your submission (I did not read carefully over all of the arguments for
> each):
>
> Patch from Thomas, Feb 2010:
>
> http://thread.gmane.org/gmane.comp.version-control.git/139919/focus=140818
>
> Discussion between us, Dec 2010:
>
> http://thread.gmane.org/gmane.comp.version-control.git/163141
>
> Patch from Michael, Apr 2011:
>
> http://thread.gmane.org/gmane.comp.version-control.git/172079
That one used to work for about one more year or so (it went through a
few rebases) but stopped working during some rework involving the
signature (signed-off-by), i.e. it puts the notes before the signed-off
now. I didn't update it because nobody seemed interested anyway (and
because branch-notes got implemented in a different, non-note way, so I
dumped that part of my workflow also).
Michael
prev parent reply other threads:[~2012-10-18 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 3:19 [PATCH] notes: mention --notes in more places Eric Blake
2012-10-17 5:14 ` Junio C Hamano
2012-10-17 5:51 ` Jeff King
2012-10-17 6:25 ` Junio C Hamano
2012-10-17 13:30 ` Eric Blake
2012-10-17 19:05 ` Jeff King
2012-10-17 21:50 ` Junio C Hamano
2012-10-18 12:11 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FF20D.6030106@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).