From: "Torsten Bögershausen" <tboegi@web.de>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Ben Walton <bdwalton@gmail.com>,
tboegi@web.de, peff@peff.net, bosch@adacore.com,
git@vger.kernel.org
Subject: Re: [PATCH] Use character class for sed expression instead of \s
Date: Thu, 25 Oct 2012 18:28:10 +0200 [thread overview]
Message-ID: <5089689A.9070301@web.de> (raw)
In-Reply-To: <C2AB6973-7BC2-45A4-836E-BB1FAAE7501C@gernhardtsoftware.com>
On 25.10.12 18:00, Brian Gernhardt wrote:
>
> On Oct 25, 2012, at 11:58 AM, Ben Walton <bdwalton@gmail.com> wrote:
>
>> Sed on Mac OS X doesn't handle \s in a sed expressions so use a more
>> portable character set expression instead.
>>
>> Signed-off-by: Ben Walton <bdwalton@gmail.com>
>
> Acked-by: Brian Gernhardt <brian@gernhardtsoftware.com>
>
> I have an identical change sitting in my git.git, I've just been too distracted by other things to commit and send it.
>
> ~~ Brian Gernhardt
Much nicer, indeed.
BTW: While we are talking CVS: (I installed a fresh version)
cvs --version
Concurrent Versions System (CVS) 1.11.23 (client/server)
And t9200 fails:
git checkout t9200-git-cvsexportcommit.sh
tb@birne:~/projects/git/git.pu/t> ./t9200-git-cvsexportcommit.sh
cvs [init aborted]: Cannot initialize repository under existing CVSROOT: `/Users/tb/projects/git/git.pu/t/trash directory.t9200-git-cvsexportcommit'
FATAL: Unexpected exit with code 1
The following fixes it, but there are possibly better solutions.
Any comments/suggestions ?
diff t9200-git-cvsexportcommit.sh t9200-git-cvsexportcommit.tb.sh
28,29c28
< mkdir "$CVSROOT" &&
< cvs init &&
---
> (cvs init || mkdir "$CVSROOT" && cvs init ) &&
next prev parent reply other threads:[~2012-10-25 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 3:54 t9401 fails with OS X sed Brian Gernhardt
2012-10-25 5:04 ` Geert Bosch
2012-10-25 8:41 ` Jeff King
2012-10-25 12:51 ` Torsten Bögershausen
2012-10-25 15:58 ` [PATCH] Use character class for sed expression instead of \s Ben Walton
2012-10-25 16:00 ` Brian Gernhardt
2012-10-25 16:28 ` Torsten Bögershausen [this message]
2012-10-25 18:08 ` Ben Walton
2012-10-25 20:09 ` Torsten Bögershausen
2012-10-26 12:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089689A.9070301@web.de \
--to=tboegi@web.de \
--cc=bdwalton@gmail.com \
--cc=bosch@adacore.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).