From: Johannes Sixt <j.sixt@viscovery.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] gitk: simplify file filtering
Date: Mon, 29 Oct 2012 07:46:36 +0100 [thread overview]
Message-ID: <508E264C.5080005@viscovery.net> (raw)
In-Reply-To: <1351185801-18543-2-git-send-email-felipe.contreras@gmail.com>
Am 10/25/2012 19:23, schrieb Felipe Contreras:
> git diff is perfectly able to do this with '-- files', no need for
> manual filtering.
It would have been very useful if you summarized what the code did before
this change.
As for the change itself, it seems to make sense to use git diff's path
limiting instead of some home-grown method.
-- Hannes
next prev parent reply other threads:[~2012-10-29 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 17:23 [PATCH 0/2] gitk: handle --full-diff corectly Felipe Contreras
2012-10-25 17:23 ` [PATCH 1/2] gitk: simplify file filtering Felipe Contreras
2012-10-29 6:46 ` Johannes Sixt [this message]
2012-10-25 17:23 ` [PATCH 2/2] gitk: handle --full-diff correctly Felipe Contreras
2012-10-29 6:52 ` Johannes Sixt
-- strict thread matches above, loose matches on Subject: below --
2012-10-19 10:56 [PATCH 0/2] gitk: fix --full-diff handling Felipe Contreras
2012-10-19 10:56 ` [PATCH 1/2] gitk: simplify file filtering Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E264C.5080005@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).