From: Jakub Suder <jakub.suder@gmail.com>
To: Marc Fournier <marc.fournier@camptocamp.com>
Cc: Avery Pennarun <apenwarr@gmail.com>, git@vger.kernel.org
Subject: Re: git-subtree.sh - regression introduced by da949cc55
Date: Thu, 11 Feb 2010 14:26:23 +0100 [thread overview]
Message-ID: <508e1531002110526u623bffbdi119d009a7af460b8@mail.gmail.com> (raw)
In-Reply-To: <20100211130837.GA29916@lonquimay.wrk.lsn.camptocamp.com>
On Thu, Feb 11, 2010 at 14:08, Marc Fournier
<marc.fournier@camptocamp.com> wrote:
> Jakub, I'm not sure I understand what this patch is supposed to fix. Could
> you provide an example ? Or a test case ?
Hi,
there is a test case for the change you're talking about - it's near
the end of test.sh, between "check if split can find proper base
without --onto" and "check_equal ..." (it was added a few commits
later). The problem was that without this commit, in some cases if I
called subtree split for an external project which was earlier added
with git subtree (in order to backport some changes to the original
project) it didn't create the new commits on top of the existing ones
like it should (just look at the test case).
I'll take a closer look at this in the evening...
Jakub Suder
next prev parent reply other threads:[~2010-02-11 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 13:08 git-subtree.sh - regression introduced by da949cc55 Marc Fournier
2010-02-11 13:26 ` Jakub Suder [this message]
2010-02-12 17:52 ` Avery Pennarun
2010-02-13 19:41 ` Jakub Suder
2010-02-13 19:49 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508e1531002110526u623bffbdi119d009a7af460b8@mail.gmail.com \
--to=jakub.suder@gmail.com \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=marc.fournier@camptocamp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).