From: gima@iki.fi
To: git@vger.kernel.org
Subject: http-backend GIT_COMMITTER_NAME & -EMAIL documentation bug
Date: Sat, 10 Nov 2012 17:26:19 +0200 [thread overview]
Message-ID: <509E721B.8070700@iki.fi> (raw)
Documentation says that envvars GIT_COMMITTER_NAME and
GIT_COMMITTER_EMAIL formed from REMOTE_USER and REMOTE_ADDR, but doesn't
mention that they are left alone if they have been set already.
Referring to:
https://github.com/git/git/blob/master/Documentation/git-http-backend.txt#L178
Source code says that they are set conditionally (referring to this part
of the source):
https://github.com/git/git/blob/master/http-backend.c#L335
And the (most recent) commit pertaining to this behavior explains the
change:
https://github.com/git/git/commit/e32a4581bcbf1cf43cd5069a0d19df07542d612a
I'm also for the possibility of custom implementations assigning those
envvars, so could the documentation be changed to reflect that?
reply other threads:[~2012-11-10 15:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509E721B.8070700@iki.fi \
--to=gima@iki.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).