git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* http-backend GIT_COMMITTER_NAME & -EMAIL documentation bug
@ 2012-11-10 15:26 gima
  0 siblings, 0 replies; only message in thread
From: gima @ 2012-11-10 15:26 UTC (permalink / raw)
  To: git

Documentation says that envvars GIT_COMMITTER_NAME and 
GIT_COMMITTER_EMAIL formed from REMOTE_USER and REMOTE_ADDR, but doesn't 
mention that they are left alone if they have been set already.
Referring to: 
https://github.com/git/git/blob/master/Documentation/git-http-backend.txt#L178

Source code says that they are set conditionally (referring to this part 
of the source):
https://github.com/git/git/blob/master/http-backend.c#L335

And the (most recent) commit pertaining to this behavior explains the 
change:
https://github.com/git/git/commit/e32a4581bcbf1cf43cd5069a0d19df07542d612a

I'm also for the possibility of custom implementations assigning those 
envvars, so could the documentation be changed to reflect that?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-10 15:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-10 15:26 http-backend GIT_COMMITTER_NAME & -EMAIL documentation bug gima

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).