From: Michael Haggerty <mhagger@alum.mit.edu>
To: git discussion list <git@vger.kernel.org>,
Jeremy White <jwhite@codeweavers.com>,
Mike McCormack <mike@codeweavers.com>
Subject: "git imap-send" with HTML preformatting broken for multipart messages
Date: Mon, 12 Nov 2012 09:43:13 +0100 [thread overview]
Message-ID: <50A0B6A1.80101@alum.mit.edu> (raw)
I just noticed that "git imap-send" with imap.preformattedHTML turned on
is broken for multipart messages. The problem is that "git imap-send"
embeds *everything* after the main email header in <pre></pre> and
HTML-escapes it, instead of splitting out the email parts and quoting
their bodies individually.
Ironically, the "git imap-send" manpage specifically lists the typical
usage as
git format-patch --signoff --stdout --attach origin | git imap-send
which is broken if imap.preformattedHTML is set.
It seems to me that rather than fix "git imap-send" (which would require
it to become more complicated), it would be better to teach "git
format-patch" how to do preformatting and restrict "git imap-send" to
sending messages verbatim to an IMAP server. Moving the functionality
to "git format-patch" would also make it possible to create preformatted
emails to be used with other transports.
Oh, and, by the way, "git imap-send" is utterly untested by the test
suite. The fact that it is intrinsically hard to test without lots of
extra infrastructure is another argument for making it as stupid as
possible.
I don't plan to work on this.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
reply other threads:[~2012-11-12 8:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0B6A1.80101@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=jwhite@codeweavers.com \
--cc=mike@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).