From: Mark Levedahl <mlevedahl@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2012, #03; Tue, 13)
Date: Wed, 14 Nov 2012 20:50:43 -0500 [thread overview]
Message-ID: <50A44A73.8020007@gmail.com> (raw)
In-Reply-To: <20121115001635.GA17370@sigill.intra.peff.net>
On 11/14/2012 07:16 PM, Jeff King wrote:
> On Wed, Nov 14, 2012 at 10:13:28PM +0100, Torsten Bögershausen wrote:
> b) Autodetection:
> (Just loud thinking), running
> $grep mingw /usr/include/w32api/winsock2.h
> * This file is part of the mingw-w64 runtime package.
> #include <_mingw_unicode.h>
>
> on cygwin 1.7.17 indicates that we can use grep in the Makefile to
> autodetect the "mingw headers"
> Hmm. Can we rely on the /usr/include bit, though?
>
> I assume a test-compile would be sufficient, but currently we do not do
> anything more magic than "uname" in the Makefile itself to determine
> defaults. Maybe it would be better to do the detection in the configure
> script? And then eventually flip the default in the Makefile once
> sufficient time has passed for most people to want the new format (which
> would not be necessary for people using autoconf, but would help people
> who do not).
>
> -Peff
>
Cygwin changed the win32api implementation, and the old is not just no
longer supported for the current release series, but virtually
impossible to even install (several new packages are now installed, the
old package is in the "obsolete" category, i.e., not available). The
older cygwin 1.5 dll + utilities can be installed afresh, so that is why
I set up to switch based upon dll version - the proposed test(s) and
configuration would be to have git maintain compatibility with an
unsupported Cygwin configuration. I just don't think this is worth the
maintenance burden, but of course I am not the maintainer, just
expressing my opinion.
I have no trouble renaming the macro to whatever seems to clarify things.
Mark
next prev parent reply other threads:[~2012-11-15 1:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 17:52 What's cooking in git.git (Nov 2012, #03; Tue, 13) Jeff King
2012-11-13 20:01 ` Junio C Hamano
2012-11-13 20:45 ` Torsten Bögershausen
2012-11-13 20:48 ` Pyeron, Jason J CTR (US)
2012-11-14 1:18 ` Mark Levedahl
2012-11-14 19:02 ` Jeff King
2012-11-14 21:13 ` Torsten Bögershausen
2012-11-15 0:16 ` Jeff King
2012-11-15 0:19 ` Junio C Hamano
2012-11-15 1:50 ` Mark Levedahl [this message]
2012-11-15 1:56 ` Jeff King
2012-11-15 5:54 ` Torsten Bögershausen
2012-11-16 18:52 ` Junio C Hamano
2012-11-17 7:11 ` Torsten Bögershausen
2012-11-15 19:05 ` Ramsay Jones
2012-11-15 19:35 ` Torsten Bögershausen
2012-11-15 23:34 ` Mark Levedahl
2012-11-13 22:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A44A73.8020007@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).