* Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
[not found] <00c601cdda4c$eb6be9a0$c243bce0$@schmitz-digital.de>
@ 2012-12-14 23:16 ` Johannes Sixt
2012-12-15 8:25 ` Joachim Schmitz
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Sixt @ 2012-12-14 23:16 UTC (permalink / raw)
To: Joachim Schmitz; +Cc: gitster, fedora.dm0, Git Mailing List
Am 14.12.2012 23:46, schrieb Joachim Schmitz:
> Johannes Sixt wrote:
>> Am 14.12.2012 20:57, schrieb David Michael:
>>> This platform previously included strings.h automatically. However,
>>> the build system now requires an explicit option to do so.
>>>
>>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>>> ---
>>> Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index fb78f7f..e84b0cb 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>> # Added manually, see above.
>>> NEEDS_SSL_WITH_CURL = YesPlease
>>> HAVE_LIBCHARSET_H = YesPlease
>>> + HAVE_STRINGS_H = YesPlease
>>> NEEDS_LIBICONV = YesPlease
>>> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>> NO_SYS_SELECT_H = UnfortunatelyYes
>>
>> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
>> should be squashed into the previous patch, shouldn't it?
>
> Patch 4/4 does not work without 3/4, Not for HP-NonStop.
That is clear from the order of the patches in the series.
To put it in a different way: Do all supported platforms still work
after 3/4, but without 4/4?
-- Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 4/4] Declare that HP NonStop systems require strings.h
2012-12-14 23:16 ` [PATCH 4/4] Declare that HP NonStop systems require strings.h Johannes Sixt
@ 2012-12-15 8:25 ` Joachim Schmitz
0 siblings, 0 replies; 6+ messages in thread
From: Joachim Schmitz @ 2012-12-15 8:25 UTC (permalink / raw)
To: 'Johannes Sixt'; +Cc: gitster, fedora.dm0, 'Git Mailing List'
> From: Johannes Sixt [mailto:j6t@kdbg.org]
> Sent: Saturday, December 15, 2012 12:17 AM
> To: Joachim Schmitz
> Cc: gitster@pobox.com; fedora.dm0@gmail.com; Git Mailing List
> Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
>
> Am 14.12.2012 23:46, schrieb Joachim Schmitz:
> > Johannes Sixt wrote:
> >> Am 14.12.2012 20:57, schrieb David Michael:
> >>> This platform previously included strings.h automatically. However,
> >>> the build system now requires an explicit option to do so.
> >>>
> >>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
> >>> ---
> >>> Makefile | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/Makefile b/Makefile
> >>> index fb78f7f..e84b0cb 100644
> >>> --- a/Makefile
> >>> +++ b/Makefile
> >>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> >>> # Added manually, see above.
> >>> NEEDS_SSL_WITH_CURL = YesPlease
> >>> HAVE_LIBCHARSET_H = YesPlease
> >>> + HAVE_STRINGS_H = YesPlease
> >>> NEEDS_LIBICONV = YesPlease
> >>> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
> >>> NO_SYS_SELECT_H = UnfortunatelyYes
> >>
> >> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> >> should be squashed into the previous patch, shouldn't it?
> >
> > Patch 4/4 does not work without 3/4, Not for HP-NonStop.
>
> That is clear from the order of the patches in the series.
>
> To put it in a different way: Do all supported platforms still work
> after 3/4, but without 4/4?
Sorry I didn't make myself clear, I left out a "and vice versa"
Bye, Jojo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/4] Declare that HP NonStop systems require strings.h
@ 2012-12-14 19:57 David Michael
2012-12-14 20:30 ` Johannes Sixt
0 siblings, 1 reply; 6+ messages in thread
From: David Michael @ 2012-12-14 19:57 UTC (permalink / raw)
To: git@vger.kernel.org; +Cc: gitster
This platform previously included strings.h automatically. However, the
build system now requires an explicit option to do so.
Signed-off-by: David Michael <fedora.dm0@gmail.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index fb78f7f..e84b0cb 100644
--- a/Makefile
+++ b/Makefile
@@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
# Added manually, see above.
NEEDS_SSL_WITH_CURL = YesPlease
HAVE_LIBCHARSET_H = YesPlease
+ HAVE_STRINGS_H = YesPlease
NEEDS_LIBICONV = YesPlease
NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
NO_SYS_SELECT_H = UnfortunatelyYes
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
2012-12-14 19:57 David Michael
@ 2012-12-14 20:30 ` Johannes Sixt
2012-12-14 22:45 ` Joachim Schmitz
2012-12-14 23:17 ` Junio C Hamano
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Sixt @ 2012-12-14 20:30 UTC (permalink / raw)
To: David Michael; +Cc: git@vger.kernel.org, gitster
Am 14.12.2012 20:57, schrieb David Michael:
> This platform previously included strings.h automatically. However, the
> build system now requires an explicit option to do so.
>
> Signed-off-by: David Michael <fedora.dm0@gmail.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index fb78f7f..e84b0cb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> # Added manually, see above.
> NEEDS_SSL_WITH_CURL = YesPlease
> HAVE_LIBCHARSET_H = YesPlease
> + HAVE_STRINGS_H = YesPlease
> NEEDS_LIBICONV = YesPlease
> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
> NO_SYS_SELECT_H = UnfortunatelyYes
If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
should be squashed into the previous patch, shouldn't it?
-- Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
2012-12-14 20:30 ` Johannes Sixt
@ 2012-12-14 22:45 ` Joachim Schmitz
2012-12-14 23:17 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Joachim Schmitz @ 2012-12-14 22:45 UTC (permalink / raw)
To: git
Johannes Sixt wrote:
> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically. However,
>> the build system now requires an explicit option to do so.
>>
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>> # Added manually, see above.
>> NEEDS_SSL_WITH_CURL = YesPlease
>> HAVE_LIBCHARSET_H = YesPlease
>> + HAVE_STRINGS_H = YesPlease
>> NEEDS_LIBICONV = YesPlease
>> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>> NO_SYS_SELECT_H = UnfortunatelyYes
>
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?
Patch 4/4 does not work without 3/4, Not for HP-NonStop.
Bye, Jojo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
2012-12-14 20:30 ` Johannes Sixt
2012-12-14 22:45 ` Joachim Schmitz
@ 2012-12-14 23:17 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2012-12-14 23:17 UTC (permalink / raw)
To: Johannes Sixt; +Cc: David Michael, git@vger.kernel.org
Johannes Sixt <j6t@kdbg.org> writes:
> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically. However, the
>> build system now requires an explicit option to do so.
>>
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>> # Added manually, see above.
>> NEEDS_SSL_WITH_CURL = YesPlease
>> HAVE_LIBCHARSET_H = YesPlease
>> + HAVE_STRINGS_H = YesPlease
>> NEEDS_LIBICONV = YesPlease
>> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>> NO_SYS_SELECT_H = UnfortunatelyYes
>
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?
Correct; otherwise 3/4 would break build on that platform.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-15 8:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <00c601cdda4c$eb6be9a0$c243bce0$@schmitz-digital.de>
2012-12-14 23:16 ` [PATCH 4/4] Declare that HP NonStop systems require strings.h Johannes Sixt
2012-12-15 8:25 ` Joachim Schmitz
2012-12-14 19:57 David Michael
2012-12-14 20:30 ` Johannes Sixt
2012-12-14 22:45 ` Joachim Schmitz
2012-12-14 23:17 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).