From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>,
Martin von Zweigbergk <martinvonz@gmail.com>,
git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed
Date: Wed, 02 Jan 2013 15:13:47 +0100 [thread overview]
Message-ID: <50E4409B.4070203@gmail.com> (raw)
In-Reply-To: <20130102084807.GB22919@elie.Belkin>
On 01/02/2013 09:48 AM, Jonathan Nieder wrote:
> Jeff King wrote:
>
>> It seems I am late to the party. But FWIW, this looks the most sane to
>> me of the patches posted in this thread.
>
> Thanks. config.status runs ./configure itself, though, so the rule
> should actually be
>
> config.status: configure.ac
> $(QUIET_GEN)$(MAKE) configure && \
> if test -f config.status; then \
> ./config.status --recheck; \
> else \
> ./configure;
> fi
>
> Rather than screw it up yet again, I'm going to sleep. :) If someone
> else corrects the patch before tomorrow, I won't mind.
>
FYI, this seems a sane approach to me. At least until Autoconf is
improved to offer better (read: some :-) support to "dynamic" package
version numbers specified at configure runtime. I hope that day
isn't too far, since the current Autoconf limitation has been causing
its share of annoyances small woes in Automake and Gnulib as well.
The only nit I have to offer is that I'd like to see more comments in
the git Makefile about why this "semi-hack" is needed.
Thanks,
Stefano
next prev parent reply other threads:[~2013-01-02 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 1:11 Makefile dependency from 'configure' to 'GIT-VERSION-FILE' Martin von Zweigbergk
2013-01-02 7:21 ` Jonathan Nieder
2013-01-02 7:47 ` Martin von Zweigbergk
2013-01-02 8:25 ` [PATCH v2] build: do not automatically reconfigure unless configure.ac changed Jonathan Nieder
2013-01-02 8:38 ` Jeff King
2013-01-02 8:48 ` Jonathan Nieder
2013-01-02 14:13 ` Stefano Lattarini [this message]
2013-01-02 16:50 ` Junio C Hamano
2013-01-02 17:07 ` Martin von Zweigbergk
2013-01-02 19:35 ` Stefano Lattarini
2013-01-02 20:25 ` Junio C Hamano
2013-01-02 20:53 ` Stefano Lattarini
2013-01-02 8:42 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E4409B.4070203@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martinvonz@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).