From: Manlio Perillo <manlio.perillo@gmail.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'git@vger.kernel.org'" <git@vger.kernel.org>
Subject: Re: git-completion.tcsh and git-completion.zsh are broken?
Date: Wed, 09 Jan 2013 21:56:58 +0100 [thread overview]
Message-ID: <50EDD99A.5090704@gmail.com> (raw)
In-Reply-To: <E59706EF8DB1D147B15BECA3322E4BDC06B99D@eusaamb103.ericsson.se>
[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 09/01/2013 21:21, Marc Khouzam ha scritto:
> [...]
>
> $zsh
> synapsis% source contrib/completion/git-completion.zsh
> (anon):6: command not found: ___main
> _git:11: command not found: _default
>
> I have disabled compinit autoload (since, I don't know how, it is able
> to find the git completion script)
>
The attached patch seems to fix it.
I'm still getting segmentation faults, but only when I try to complete
git rm contrib/<TAB> (in the git repository).
Sorry if this is a plain patch.
The code is simply copied from the one found in git-completion.bash.
I also noted that zsh on my system have preinstalled git completion
support (enabled with autoload).
The code is not the one available in the git source tree.
I don't know if the code is from Debian or zsh.
>
> $tcsh
> synapsis:~/projects/git/contrib/git> source ~/.git-completion.tcsh
> synapsis:~/projects/git/contrib/git> git show HEAD:<TAB>
>
> does not show the file list for the tree object in the HEAD
>
>> Hm. That doesn't work for me either. I'll look into it.
>> It is not caused by your changes.
>
> another problem is that a space is added after a directory name.
>
>> The lastest version of git-completion.tcsh in the pu branch should
>> fix that problem. It was committed yesterday so you may not have it.
>
Ok, thanks.
Regards Manlio
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlDt2ZoACgkQscQJ24LbaUR/ggCfYNbRrM1HzHWYDwkejNP/hD9k
ShkAnjv3JapVXPlj59CakY4kwaE/4z5J
=qYP5
-----END PGP SIGNATURE-----
[-- Attachment #2: git-completion.zsh.patch --]
[-- Type: text/x-diff, Size: 320 bytes --]
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 4577502..4aeda2a 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -75,4 +75,5 @@ _git ()
return _ret
}
-_git
+autoload -U +X compinit && compinit
+compdef _git git gitk
prev parent reply other threads:[~2013-01-09 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 19:17 git-completion.tcsh and git-completion.zsh are broken? Manlio Perillo
2013-01-09 20:21 ` Marc Khouzam
2013-01-09 20:56 ` Manlio Perillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EDD99A.5090704@gmail.com \
--to=manlio.perillo@gmail.com \
--cc=git@vger.kernel.org \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).