From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2013, #07; Thu, 17)
Date: Fri, 18 Jan 2013 16:08:57 +0100 [thread overview]
Message-ID: <50F96589.4010408@alum.mit.edu> (raw)
In-Reply-To: <7vsj5zs5y2.fsf@alter.siamese.dyndns.org>
On 01/18/2013 01:14 AM, Junio C Hamano wrote:
> [...]
> * mh/imap-send-shrinkage (2013-01-15) 14 commits
> - imap-send.c: simplify logic in lf_to_crlf()
> - imap-send.c: fold struct store into struct imap_store
> - imap-send.c: remove unused field imap_store::uidvalidity
> - imap-send.c: use struct imap_store instead of struct store
> - imap-send.c: remove unused field imap_store::trashnc
> - imap-send.c: remove namespace fields from struct imap
> - imap-send.c: remove struct imap argument to parse_imap_list_l()
> - imap-send.c: inline parse_imap_list() in parse_list()
> - imap-send.c: remove some unused fields from struct store
> - imap-send.c: remove struct message
> - imap-send.c: remove struct store_conf
> - iamp-send.c: remove unused struct imap_store_conf
> - imap-send.c: remove struct msg_data
> - imap-send.c: remove msg_data::flags, which was always zero
>
> Remove a lot of unused code from "git imap-send".
>
> With a further comment fixup in patch #6, this seems ready for
> 'next'.
> Expecting a reroll.
I'm confused. It seems like you are referring to the comment
improvement suggested by Jonathan Nieder [1] that you have already
incorporated [2] into mh/imap-send-shrinkage. If you think there is
something that needs rerolling, please explain.
Thanks,
Michael
[1] http://permalink.gmane.org/gmane.comp.version-control.git/213672
[2] http://permalink.gmane.org/gmane.comp.version-control.git/213681
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2013-01-18 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 0:14 What's cooking in git.git (Jan 2013, #07; Thu, 17) Junio C Hamano
2013-01-18 15:08 ` Michael Haggerty [this message]
2013-01-18 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F96589.4010408@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).