From: Manlio Perillo <manlio.perillo@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>,
wookietreiber <kizkizzbangbang@googlemail.com>,
git@vger.kernel.org
Subject: Re: [feature request] git add completion should exclude staged content
Date: Mon, 28 Jan 2013 21:13:25 +0100 [thread overview]
Message-ID: <5106DBE5.6040507@gmail.com> (raw)
In-Reply-To: <5106A5CE.3000800@drmicha.warpmail.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 28/01/2013 17:22, Michael J Gruber ha scritto:
> [...]
>> The patch will suggest (for git add command), all the files that are
>> candidate to be added to the index file.
>>
>> Please, test it and report any behaviour you think is incorrect.
>
> OK, that seems to work and to be quite helpful.
>
> Minor nit: "git add -u" could use the same fileset as "git commit". But
> I don't know whether completion can act upon the presence of options.
It is possible, but I have not implemented since I was not sure about it
and I wanted to avoid to make the patch more hard to review.
I will work on it after the patch is approved.
> Currently, it also includes untracked files (just like without -u) but
> omits unmodified and ignored ones, which is already quite an improvement.
>
> I won't be able to review the completion code but may contribute a few
> lines to t/t9902-completion.sh, possibly.
>
Ah, I missed this test; thanks.
The proposed patch must update it.
Regards Manlio
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlEG2+UACgkQscQJ24LbaURstACfdNxuFvaokBSTls20bSQ7jPHA
8I0An3fX6oRKuc2lzAgPVBLjsbjbw91V
=igwr
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-01-28 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 17:21 [feature request] git add completion should exclude staged content wookietreiber
2013-01-27 23:00 ` Junio C Hamano
2013-01-28 9:26 ` Manlio Perillo
2013-01-28 12:52 ` Michael J Gruber
2013-01-28 14:02 ` Manlio Perillo
2013-01-28 16:22 ` Michael J Gruber
2013-01-28 17:52 ` Junio C Hamano
2013-01-28 20:16 ` Manlio Perillo
2013-01-30 14:06 ` Marc Khouzam
2013-01-30 18:24 ` Manlio Perillo
2013-01-30 18:55 ` Marc Khouzam
2013-01-30 19:58 ` Manlio Perillo
2013-01-28 20:13 ` Manlio Perillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5106DBE5.6040507@gmail.com \
--to=manlio.perillo@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kizkizzbangbang@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).