From: TJ <git@iam.tj>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/1] Introduce new build variables INSTALL_MODE_EXECUTABLE and INSTALL_MODE_DATA.
Date: Thu, 31 Jan 2013 16:55:03 +0000 [thread overview]
Message-ID: <510AA1E7.9070704@iam.tj> (raw)
In-Reply-To: <7vtxpxic5l.fsf@alter.siamese.dyndns.org>
On 31/01/13 15:51, Junio C Hamano wrote:
> TJ <git@iam.tj> writes:
>
>> + $(INSTALL) -d -m $(INSTALL_MODE_EXECUTABLE) $(DESTDIR)$(man1dir)
>> + $(INSTALL) -d -m $(INSTALL_MODE_EXECUTABLE) $(DESTDIR)$(man5dir)
>> + $(INSTALL) -d -m $(INSTALL_MODE_EXECUTABLE) $(DESTDIR)$(man7dir)
>> + $(INSTALL) -m $(INSTALL_MODE_DATA) $(DOC_MAN1) $(DESTDIR)$(man1dir)
>> + $(INSTALL) -m $(INSTALL_MODE_DATA) $(DOC_MAN5) $(DESTDIR)$(man5dir)
>> + $(INSTALL) -m $(INSTALL_MODE_DATA) $(DOC_MAN7) $(DESTDIR)$(man7dir)
>
> I'm tempted to suggest
>
> INSTALL_DIR = $(INSTALL) -d -m 755
> INSTALL_DATA = $(INSTALL) -m 644
> INSTALL_PROGRAM = $(INSTALL) -m 755
>
> The number of lines the patch needs to touch will be the same, but
> the resulting lines will not have many $(INSTALL_MODE_BLAH) shouting
> at us.
I did contemplate that but was concerned it might be seen as interfering unduly with
the tool name/path settings, as opposed to their options.
> Besides, you would want to differentiate the two kinds of 755 anyway
> (I'd prefer INSTALL_PROGRAM to use -m 555 personally, for example).
Yes, I think I lost that one in the mists of sed-land when making the changes :)
I'll revise the patch based on received comments and post the revision tomorrow.
next prev parent reply other threads:[~2013-01-31 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 2:08 [PATCH 1/1] Introduce new build variables INSTALL_MODE_EXECUTABLE and INSTALL_MODE_DATA TJ
2013-01-31 13:25 ` Jeff Epler
2013-01-31 15:48 ` Junio C Hamano
2013-01-31 15:51 ` Junio C Hamano
2013-01-31 16:55 ` TJ [this message]
2013-02-25 6:54 ` Junio C Hamano
2013-02-25 14:46 ` TJ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510AA1E7.9070704@iam.tj \
--to=git@iam.tj \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).