From: Stephen Boyd <sboyd@codeaurora.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] run-command: Be more informative about what failed
Date: Thu, 31 Jan 2013 10:05:09 -0800 [thread overview]
Message-ID: <510AB255.40302@codeaurora.org> (raw)
In-Reply-To: <7vfw1hiami.fsf@alter.siamese.dyndns.org>
On 01/31/13 08:24, Junio C Hamano wrote:
> Stephen Boyd <sboyd@codeaurora.org> writes:
>
>> While debugging an error with verify_signed_buffer() the error
>> messages from run-command weren't very useful:
>>
>> error: cannot create pipe for gpg: Too many open files
>> error: could not run gpg.
>>
>> because they didn't indicate *which* pipe couldn't be created.
> For the message emitted here with your update (or without for that
> matter) to be useful, it has to hold that there is a single leaker,
> that leaker fails in this codepath, and that there is nobody else
> involved. Otherwise, you may be able to tell that one caller could
> not create its stdin, but the reason it couldn't may be because
> somebody else consumed all the available file descriptors.
>
> I am not opposed to this change per-se, but I am not sure that
> saying "stdin" etc. makes the message more useful for the purpose of
> debugging.
It helped me avoid firing up gdb, but if you don't see much use feel
free to ignore this patch.
>
>> For example, the above error now prints:
>>
>> error: cannot create stderr pipe for gpg: Too many open files
>> error: could not run gpg.
> I'd prefer to see these names spelled out (e.g. "standard error")
> in any case.
Sure, I can do that.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-01-31 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 2:01 [PATCH 0/3] GPG running out of pipes fixes Stephen Boyd
2013-01-31 2:01 ` [PATCH 1/3] gpg: Close stderr once finished with it in verify_signed_buffer() Stephen Boyd
2013-01-31 5:50 ` Jeff King
2013-01-31 18:06 ` Stephen Boyd
2013-01-31 18:18 ` [PATCHv2 " Stephen Boyd
2013-01-31 22:37 ` Jeff King
2013-01-31 2:01 ` [PATCH 2/3] run-command: Be more informative about what failed Stephen Boyd
2013-01-31 16:24 ` Junio C Hamano
2013-01-31 18:05 ` Stephen Boyd [this message]
2013-01-31 22:35 ` Jeff King
2013-01-31 23:57 ` Junio C Hamano
2013-01-31 2:01 ` [PATCH 3/3] gpg: Allow translation of more error messages Stephen Boyd
2013-01-31 18:20 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510AB255.40302@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).