From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Erik Faye-Lund <kusmabite@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/5] Fix msvc build
Date: Mon, 25 Feb 2013 09:25:39 +0100 [thread overview]
Message-ID: <512B2003.804@viscovery.net> (raw)
In-Reply-To: <7vehg4288w.fsf@alter.siamese.dyndns.org>
Am 2/25/2013 7:54, schrieb Junio C Hamano:
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>> As I mentioned recently, while discussing a cygwin specific patch
>> (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the
>> MSVC build is broken for me.
>>
>> The first 4 patches fix the MSVC build for me. The final patch is
>> not really related to fixing the build, but it removed some make
>> warnings which were quite irritating ...
>>
>> Note that I used the Makefile, with the Visual C++ 2008 command
>> line compiler on Windows XP (SP3), to build a vanilla git on MinGW.
>> I'm not subscribed to the msysgit mailing list, nor do I follow the
>> msysgit fork of git, so these patches may conflict with commits in
>> their repository.
>
> Did anything further happen to this topic in the Windows land?
I successfully built with MSVC with these patches (but I am not using the
result anywhere nor did I attempt to run the test suite).
More importantly, I'm using git on Windows ("MinGW flavor") with these
patches in production, so there are no obvious regressions.
Feel free to add my
Tested-by: Johannes Sixt <j6t@kdbg.org>
but if you don't have the patches around, I can resend them.
-- Hannes
next prev parent reply other threads:[~2013-02-25 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:26 [PATCH 0/5] Fix msvc build Ramsay Jones
2013-01-31 18:57 ` Johannes Schindelin
2013-01-31 19:28 ` Junio C Hamano
2013-02-25 6:54 ` Junio C Hamano
2013-02-25 8:25 ` Johannes Sixt [this message]
2013-02-25 19:01 ` Johannes Schindelin
2013-02-26 19:48 ` [msysGit] " Johannes Sixt
2013-02-26 19:06 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512B2003.804@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kusmabite@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).