git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Elijah Newren" <newren@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Pascal Obry" <pascal.obry@gmail.com>,
	git@vger.kernel.org, "Pascal Obry" <pascal@obry.net>
Subject: Re: [PATCH] Add interactive option in rebase command completion list.
Date: Sun, 6 Apr 2008 12:33:29 -0600	[thread overview]
Message-ID: <51419b2c0804061133t20f7606y2ebe8f921b6c3781@mail.gmail.com> (raw)
In-Reply-To: <7vprt2sv60.fsf@gitster.siamese.dyndns.org>

On Sun, Apr 6, 2008 at 12:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Pascal Obry <pascal.obry@gmail.com> writes:
>
>  > -             __gitcomp "--onto --merge --strategy"
>  > +             __gitcomp "--onto --merge --strategy --interactive"
>
>  I personally do not think this is worth it where a single "-i" is enough.

One advantage of bash completion, in my opinion, is being able to be
reminded of option names by tabbing twice to get a list of possible
completions.  For exactly such a case, I'd be in favor of this patch.

Just my $0.02,
Elijah

  reply	other threads:[~2008-04-06 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-06 17:32 [PATCH] Add interactive option in rebase command completion list Pascal Obry
2008-04-06 18:19 ` Junio C Hamano
2008-04-06 18:33   ` Elijah Newren [this message]
2008-04-06 18:46   ` Pascal Obry
2008-04-06 19:09     ` Shawn O. Pearce
2008-04-06 20:08       ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51419b2c0804061133t20f7606y2ebe8f921b6c3781@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pascal.obry@gmail.com \
    --cc=pascal@obry.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).