git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Elijah Newren" <newren@gmail.com>
To: "Govind Salinas" <govind@sophiasuchtig.com>
Cc: "Steven Walter" <stevenrwalter@gmail.com>,
	"Jakub Narebski" <jnareb@gmail.com>,
	git@vger.kernel.org
Subject: Revert behavior [Was: Re: [ANNOUNCE] yap: Yet Another (Git) Porcelain]
Date: Tue, 9 Sep 2008 07:26:43 -0600	[thread overview]
Message-ID: <51419b2c0809090626p2196c590j7569fb471e470f0d@mail.gmail.com> (raw)

Hi,

On Mon, Sep 8, 2008 at 10:25 PM, Govind Salinas
<govind@sophiasuchtig.com> wrote:
> On Mon, Sep 8, 2008 at 8:05 PM, Steven Walter <stevenrwalter@gmail.com> wrote:

> I had some very different ideas along the lines of reducing the number of
> commands (where the commands do something similar just DWIM rather
> than force me to remember or read docs on different commands), making
> commands look similar to commands from other SCMs (revert should do
> what it does for me in all the other SCMs that I have used, which is to
> checkout the HEAD copy into the working directory)

Your description of revert in various systems isn't quite accurate; it
isn't necessarily HEAD, since most systems (at least bzr and hg) can
also revert files to revisions earlier than HEAD.  In fact, questions
of how to do that have come up several times on this list, so you
wouldn't want to exclude that case.  Also, the revert behavior of git
(minus perhaps the default auto-commit) comes in pretty handy too
sometimes, and I can't easily find it in other systems (I suspect many
just drop back to diff + patch to handle the case that git provides).

I don't see why the revert command can't support all these cases that
users want (though you'd need to add flags like --since and --in to
differentiate between reverting the changes since a given commit or in
a given commit).  Doing so has the added advantage that you can
avoid/deprecate/hide/whatever the second forms of the checkout and
reset commands of git, which have long caused confusion for users in
understanding the differences between them and the revert command.

Elijah

P.S. Yes, EasyGit's revert was designed this way.  Don't look to eg
for implementation guidance, though -- I botched it, and there's a few
bugs in it due to my mistakes.  I'll be fixing it...when I get a
little bit of time.

             reply	other threads:[~2008-09-09 13:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 13:26 Elijah Newren [this message]
2008-09-09 13:38 ` Revert behavior [Was: Re: [ANNOUNCE] yap: Yet Another (Git) Porcelain] Jakub Narebski
2008-09-09 16:37   ` Govind Salinas
2008-09-09 17:29     ` Steven Walter
2008-09-09 20:19       ` Elijah Newren
2008-09-09 21:50         ` Steven Walter
2008-09-09 23:02           ` Elijah Newren
2008-09-09 20:20   ` Elijah Newren
2008-09-09 21:28   ` Petr Baudis
2008-09-09 21:39     ` Steven Walter
2008-09-09 22:10       ` Revert behavior Junio C Hamano
2008-09-09 22:30         ` Steven Walter
2008-09-09 22:51         ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51419b2c0809090626p2196c590j7569fb471e470f0d@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=govind@sophiasuchtig.com \
    --cc=jnareb@gmail.com \
    --cc=stevenrwalter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).