git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Mike Ralphson <mike.ralphson@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] EasyGit (eg) 0.97
Date: Fri, 30 Jan 2009 13:22:36 -0700	[thread overview]
Message-ID: <51419b2c0901301222l2b722714v48db0039180d262b@mail.gmail.com> (raw)
In-Reply-To: <20090130200307.GA3054@coredump.intra.peff.net>

On Fri, Jan 30, 2009 at 1:03 PM, Jeff King <peff@peff.net> wrote:
> Ah, OK. I just peeked through the 'eg' source. It looks like you may
> have replicated the same bug that I just fixed in git. :)
>
> You  want to make sure that "eg" is the last process to die (i.e.,
> _after_ the pager). Otherwise after it dies, less has trouble reading
> from the terminal (I don't know for sure, but I assume this has to do
> with the shell making "eg" the process group leader and magic about
> process groups and controlling terminals).
>
> I think perl may even do the wait() for you under ordinary
> circumstances. But, for example, if I kill "eg" with a signal (say, by
> hitting ^C), then it will die but the pager will live on. In git, we
> catch the signal and wait() before dying.
>
> So I don't know for sure that is your problem (it really depends on how
> much magic perl is doing behind the scenes with wait()ing on children,
> and I don't recall the exact details of that). But it is something to
> look into.

Thanks for the tips; I'll try to take a look and see what I can figure out.


Elijah

  reply	other threads:[~2009-01-30 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 16:42 [ANNOUNCE] EasyGit (eg) 0.97 Elijah Newren
2009-01-30 16:59 ` Mike Ralphson
2009-01-30 18:35   ` Elijah Newren
2009-01-30 19:47     ` Jeff King
2009-01-30 20:03       ` Jeff King
2009-01-30 20:22         ` Elijah Newren [this message]
2009-01-30 20:21       ` Elijah Newren
2009-01-30 20:29         ` Jeff King
2009-01-30 22:55           ` Elijah Newren
2009-01-31  7:25             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51419b2c0901301222l2b722714v48db0039180d262b@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mike.ralphson@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).