git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elijah Newren <newren@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Mike Ralphson <mike.ralphson@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] EasyGit (eg) 0.97
Date: Fri, 30 Jan 2009 15:55:28 -0700	[thread overview]
Message-ID: <51419b2c0901301455h32775947rfc4483fd5a5b6c2a@mail.gmail.com> (raw)
In-Reply-To: <20090130202917.GA3370@coredump.intra.peff.net>

On Fri, Jan 30, 2009 at 1:29 PM, Jeff King <peff@peff.net> wrote:
> If you pass --color on the command line, it is equivalent to "color =
> always" (whereas the default is "auto", which turns it on only if output
> is to a tty).
>
> So you would have to read color.diff yourself and then decide whether to
> add --color.

It looks like I can also set the environment variable GIT_PAGER_IN_USE
to achieve the same effects (and I don't even need to do so for most
commands, such as diff, just those whose output I'm parsing and
possibly tweaking).

> Note that in general you are playing things a bit risky with these sorts
> of outputs. You are calling porcelain (like log and status) and piping
> it into your program. There's no guarantee that user config might not be
> affecting the results of those programs.
>
> But I think that is sort of the nature of "eg": to be a thin wrapper
> around git. So maybe it is OK for your use.

Right, I considered switching eg to use git plumbing commands to
insulate from issues like this, but the problem is that if git output
changes then the eg output really should change too (or else I should
have a very specific reason for not changing it).  This almost
certainly means that I'll have to bump the minimum git version to be
used with eg at some point, but that seemed the most reasonable path
for eg.

  reply	other threads:[~2009-01-30 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 16:42 [ANNOUNCE] EasyGit (eg) 0.97 Elijah Newren
2009-01-30 16:59 ` Mike Ralphson
2009-01-30 18:35   ` Elijah Newren
2009-01-30 19:47     ` Jeff King
2009-01-30 20:03       ` Jeff King
2009-01-30 20:22         ` Elijah Newren
2009-01-30 20:21       ` Elijah Newren
2009-01-30 20:29         ` Jeff King
2009-01-30 22:55           ` Elijah Newren [this message]
2009-01-31  7:25             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51419b2c0901301455h32775947rfc4483fd5a5b6c2a@mail.gmail.com \
    --to=newren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mike.ralphson@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).