Re: [RFC with a proof of concept PATCH] Add Bonsai-like query options to gitk

[Elijah Newren <newren@gmail.com>]

(Sorry, resending my own email since I accidentally left of the cc's.)

On Mon, Mar 23, 2009 at 4:07 AM, Paul Mackerras <paulus@samba.org> wrote:
> Elijah Newren <newren@gmail.com> writes:
>
>> (If you like screenshots, I've got some before & after ones up at
>> http://www.gnome.org/~newren/temp/gitk/gitk-edit-view.html, but
>> remember that this is just a proof of concept and call for comments.)
>
> Looks reasonable... have you developed the patch any further?

Yes, I have.  There was a cosmetic tweak or two, but the main change
was fixing the view remembering stuff that I noted I broke in the
original patch.  I've also showed this modified dialog in two
different git presentations, to dozens of new and potential users of
git, and it seems to have been well received[1].  I'll send a
follow-up patch shortly (I'd copy it inline, but I'm afraid gmail will
screw it up).

Elijah


[1] For one of the two groups, a lack of a Bonsai replacement actually
derailed their conversion to svn about a year ago.  This group was
very interested in git after my presentation and seemed satisfied with
gitk (with my proposed changes) as a replacement for Bonsai.  There
was one minor question that did come up each time -- one person in
each presentation asked why it is that when you specify --author=smith
(at the command line or via the equivalent box in the gui), you also
see commits authored by e.g. "jones" in gitk; however, once I
mentioned the different colored dots in gitk and the fact that it's
showing the commits that the patches are relative to, there was no
more issue and everyone was happy.  I'm guessing it'd be slightly more
intuitive to them to have gitk filter out these parent commits from
the graph unless they also meet the search criteria, but it's a pretty
minor issue.