From: Elijah Newren <newren@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, kusmabite@gmail.com
Subject: Re: [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees
Date: Mon, 22 Jun 2009 07:12:03 -0600 [thread overview]
Message-ID: <51419b2c0906220612l5ce0ee4fs6466bb13b001872f@mail.gmail.com> (raw)
In-Reply-To: <200906210817.51520.j6t@kdbg.org>
On Sun, Jun 21, 2009 at 12:17 AM, Johannes Sixt<j6t@kdbg.org> wrote:
> On Samstag, 20. Juni 2009, newren@gmail.com wrote:
>> -test_expect_success 'tree_tag' 'git fast-export tree_tag'
>> +test_expect_success 'tree_tag' '
>> + mkdir result &&
>> + cd result &&
>> + git init &&
>> + cd ..
>> + git fast-export tree_tag | (cd result && git fast-import)
>> +'
>
> You should make this
>
> test_expect_success 'tree_tag' '
> mkdir result &&
> (cd result && git init) &&
> git fast-export tree_tag > fe-stream &&
> (cd result && git fast-import < fe-stream)
> '
>
> in order to (1) not remain in the wrong directory if git init fails, and (2)
> to catch failures in git fast-export.
Thanks for the tips; I've sent a new patch series with these changes
(except that the second fe-stream needs a ../ in front of it), as well
as the changes suggested by Stephen Boyd in the other email in this
thread.
Elijah
next prev parent reply other threads:[~2009-06-22 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 4:36 A few fast-export fixups newren
2009-06-20 4:36 ` [PATCH 1/7] fast-export: Omit tags that tag trees newren
2009-06-20 17:31 ` Jeff King
2009-06-20 18:01 ` Elijah Newren
2009-06-20 18:52 ` Jeff King
2009-06-20 4:36 ` [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees newren
2009-06-21 5:53 ` Stephen Boyd
2009-06-21 6:17 ` Johannes Sixt
2009-06-22 13:12 ` Elijah Newren [this message]
2009-06-20 4:36 ` [PATCH 3/7] fast-export: Make sure we show actual ref names instead of "(null)" newren
2009-06-20 4:37 ` [PATCH 4/7] fast-export: Do parent rewriting to avoid dropping relevant commits newren
2009-06-20 4:37 ` [PATCH 5/7] fast-export: Add a --tag-of-filtered-object option for newly dangling tags newren
2009-06-20 4:37 ` [PATCH 6/7] Add new fast-export testcases newren
2009-06-20 4:37 ` [PATCH 7/7] fast-export: Document the fact that git-rev-list arguments are accepted newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51419b2c0906220612l5ce0ee4fs6466bb13b001872f@mail.gmail.com \
--to=newren@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).